Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc

Issue 2183883002: Implement deactivating SubresourceFilter for document. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@integrate_ruleset
Patch Set: Address more comments from engedy@ Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc
diff --git a/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc b/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc
index 2a5cfc0cccbe29b521e766f34381ba0d9d8d6aaf..c6f34e2b9099c419871aa257d1623d6fbdcc5a7f 100644
--- a/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc
+++ b/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc
@@ -244,6 +244,8 @@ TEST_F(SubresourceFilterAgentTest, Disabled_HistogramSamples) {
histogram_tester.ExpectTotalCount(
"SubresourceFilter.DocumentLoad.RulesetIsAvailable", 0);
histogram_tester.ExpectTotalCount(
+ "SubresourceFilter.DocumentLoad.NumSubresourceLoads.Total", 0);
+ histogram_tester.ExpectTotalCount(
"SubresourceFilter.DocumentLoad.NumSubresourceLoads.Evaluated", 0);
histogram_tester.ExpectTotalCount(
"SubresourceFilter.DocumentLoad.NumSubresourceLoads.Disallowed", 0);
@@ -261,6 +263,8 @@ TEST_F(SubresourceFilterAgentTest,
histogram_tester.ExpectUniqueSample(
"SubresourceFilter.DocumentLoad.RulesetIsAvailable", 0, 1);
histogram_tester.ExpectTotalCount(
+ "SubresourceFilter.DocumentLoad.NumSubresourceLoads.Total", 0);
+ histogram_tester.ExpectTotalCount(
"SubresourceFilter.DocumentLoad.NumSubresourceLoads.Evaluated", 0);
histogram_tester.ExpectTotalCount(
"SubresourceFilter.DocumentLoad.NumSubresourceLoads.MatchedRules", 0);
@@ -294,6 +298,9 @@ TEST_F(SubresourceFilterAgentTest, Enabled_HistogramSamples) {
static_cast<int>(ActivationState::ENABLED), 2);
histogram_tester.ExpectUniqueSample(
"SubresourceFilter.DocumentLoad.RulesetIsAvailable", 1, 2);
+ EXPECT_THAT(histogram_tester.GetAllSamples(
+ "SubresourceFilter.DocumentLoad.NumSubresourceLoads.Total"),
+ ::testing::ElementsAre(base::Bucket(2, 1), base::Bucket(3, 1)));
EXPECT_THAT(
histogram_tester.GetAllSamples(
"SubresourceFilter.DocumentLoad.NumSubresourceLoads.Evaluated"),
@@ -330,6 +337,8 @@ TEST_F(SubresourceFilterAgentTest, DryRun_HistogramSamples) {
histogram_tester.ExpectUniqueSample(
"SubresourceFilter.DocumentLoad.RulesetIsAvailable", 1, 1);
histogram_tester.ExpectUniqueSample(
+ "SubresourceFilter.DocumentLoad.NumSubresourceLoads.Total", 3, 1);
+ histogram_tester.ExpectUniqueSample(
"SubresourceFilter.DocumentLoad.NumSubresourceLoads.Evaluated", 3, 1);
histogram_tester.ExpectUniqueSample(
"SubresourceFilter.DocumentLoad.NumSubresourceLoads.MatchedRules", 2, 1);

Powered by Google App Engine
This is Rietveld 408576698