Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/IDLDictionaryBase.cpp

Issue 2183623004: Add IDLDictionaryBase (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update class description Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/IDLDictionaryBase.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/IDLDictionaryBase.cpp b/third_party/WebKit/Source/bindings/core/v8/IDLDictionaryBase.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..873860aeaae0954f71696bde51ed51beb360d620
--- /dev/null
+++ b/third_party/WebKit/Source/bindings/core/v8/IDLDictionaryBase.cpp
@@ -0,0 +1,26 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "bindings/core/v8/IDLDictionaryBase.h"
+
+namespace blink {
+
+IDLDictionaryBase::IDLDictionaryBase()
Yuki 2016/07/26 10:59:55 nit: You can make this constructor an inline funct
bashi 2016/07/27 02:36:33 I had a vague recollection that some linkers compl
+{
+}
+
+IDLDictionaryBase::~IDLDictionaryBase()
Yuki 2016/07/26 10:59:55 nit: ditto. It's possible that compilers do optim
bashi 2016/07/27 02:36:33 Done.
+{
+}
+
+v8::Local<v8::Value> IDLDictionaryBase::toV8Impl(v8::Local<v8::Object>, v8::Isolate*) const
+{
+ return v8::Local<v8::Value>();
Yuki 2016/07/26 10:59:55 NOTREACHED()?
bashi 2016/07/27 02:36:33 Done.
+}
+
+DEFINE_TRACE(IDLDictionaryBase)
+{
+}
+
+} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698