Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1000)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/IDLDictionaryBase.cpp

Issue 2183623004: Add IDLDictionaryBase (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update class description Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "bindings/core/v8/IDLDictionaryBase.h"
6
7 namespace blink {
8
9 IDLDictionaryBase::IDLDictionaryBase()
Yuki 2016/07/26 10:59:55 nit: You can make this constructor an inline funct
bashi 2016/07/27 02:36:33 I had a vague recollection that some linkers compl
10 {
11 }
12
13 IDLDictionaryBase::~IDLDictionaryBase()
Yuki 2016/07/26 10:59:55 nit: ditto. It's possible that compilers do optim
bashi 2016/07/27 02:36:33 Done.
14 {
15 }
16
17 v8::Local<v8::Value> IDLDictionaryBase::toV8Impl(v8::Local<v8::Object>, v8::Isol ate*) const
18 {
19 return v8::Local<v8::Value>();
Yuki 2016/07/26 10:59:55 NOTREACHED()?
bashi 2016/07/27 02:36:33 Done.
20 }
21
22 DEFINE_TRACE(IDLDictionaryBase)
23 {
24 }
25
26 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698