third_party/WebKit/Source/bindings/templates/dictionary_impl.h - Issue 2183623004: Add IDLDictionaryBase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/dictionary_impl.h

Issue 2183623004: Add IDLDictionaryBase (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update class description Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/templates/dictionary_impl.h

diff --git a/third_party/WebKit/Source/bindings/templates/dictionary_impl.h b/third_party/WebKit/Source/bindings/templates/dictionary_impl.h

index daabee391acbf9d15b9c87ab086b763eb9b7651f..78f54dc94bef2cd8fa5f9c4153a1fa367168573f 100644

--- a/third_party/WebKit/Source/bindings/templates/dictionary_impl.h

+++ b/third_party/WebKit/Source/bindings/templates/dictionary_impl.h

@@ -24,6 +24,7 @@ public:

{% endif %}

{% endfor %}

+ v8::Local<v8::Value> toV8Impl(v8::Local<v8::Object>, v8::Isolate*) const override;

Yuki 2016/07/26 10:59:55 nit: Let's explicitly say |creationContext| becaus

bashi 2016/07/27 02:36:33 Done.

DECLARE_VIRTUAL_TRACE();

private: