Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2183493002: Add a merely pass-through QuicMultipathSentPacketManager. Protected behind blocked flag FLAGS_quic_… (Closed)

Created:
4 years, 4 months ago by Ryan Hamilton
Modified:
4 years, 4 months ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a merely pass-through QuicMultipathSentPacketManager. Protected behind blocked flag FLAGS_quic_enable_multipath. Merge internal change: 127821412

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+1362 lines, -59 lines) Patch
M net/net.gypi View 3 chunks +5 lines, -0 lines 0 comments Download
M net/quic/quic_connection.h View 2 chunks +3 lines, -1 line 0 comments Download
M net/quic/quic_connection.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_connection_test.cc View 19 chunks +36 lines, -31 lines 0 comments Download
M net/quic/quic_flow_controller_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/quic/quic_http_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
A net/quic/quic_multipath_sent_packet_manager.h View 1 chunk +223 lines, -0 lines 1 comment Download
A net/quic/quic_multipath_sent_packet_manager.cc View 1 chunk +520 lines, -0 lines 1 comment Download
A net/quic/quic_multipath_sent_packet_manager_test.cc View 1 chunk +384 lines, -0 lines 1 comment Download
M net/quic/quic_protocol.h View 2 chunks +6 lines, -1 line 0 comments Download
M net/quic/quic_sent_packet_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_sent_packet_manager_interface.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_server_session_base.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M net/quic/quic_server_session_base_test.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/quic/quic_session_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M net/quic/quic_utils.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.h View 2 chunks +10 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.cc View 3 chunks +20 lines, -4 lines 0 comments Download
A net/quic/test_tools/quic_multipath_sent_packet_manager_peer.h View 1 chunk +27 lines, -0 lines 1 comment Download
A net/quic/test_tools/quic_multipath_sent_packet_manager_peer.cc View 1 chunk +25 lines, -0 lines 1 comment Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +67 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 2181773002 Patch 1

Messages

Total messages: 4 (1 generated)
Ryan Hamilton
4 years, 4 months ago (2016-07-25 22:08:12 UTC) #2
Zhongyi Shi
lgtm, modulo missing chromium license header for new files. You could add them in the ...
4 years, 4 months ago (2016-07-25 22:30:34 UTC) #3
Ryan Hamilton
4 years, 4 months ago (2016-07-25 23:06:06 UTC) #4 
On 2016/07/25 22:30:34, Zhongyi Shi wrote:
> lgtm, modulo missing chromium license header for new files. You could add them
> in the final landing CL.

Indeed! Done in final (which I've not sent out yet)

Powered by Google App Engine
This is Rietveld 408576698