Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2181773002: Add a test helper method to construct a full CHLO. (Closed)

Created:
4 years, 5 months ago by Ryan Hamilton
Modified:
4 years, 4 months ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@127821412
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a test helper method to construct a full CHLO. Merge internal change: 127851984

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -0 lines) Patch
M net/net.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.h View 1 chunk +12 lines, -0 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 2 chunks +86 lines, -0 lines 0 comments Download
A net/quic/test_tools/crypto_test_utils_test.cc View 1 chunk +122 lines, -0 lines 2 comments Download

Depends on Patchset:

Issue 2183493002 Patch 1

Dependent Patchsets:

Issue 2177843004 Patch 1

Messages

Total messages: 4 (1 generated)
Ryan Hamilton
4 years, 5 months ago (2016-07-25 22:13:54 UTC) #2
Zhongyi Shi
lgtm, modulo missing chromium license header for the new file. https://codereview.chromium.org/2181773002/diff/1/net/quic/test_tools/crypto_test_utils_test.cc File net/quic/test_tools/crypto_test_utils_test.cc (right): https://codereview.chromium.org/2181773002/diff/1/net/quic/test_tools/crypto_test_utils_test.cc#newcode1 ...
4 years, 5 months ago (2016-07-25 22:33:49 UTC) #3
Ryan Hamilton
4 years, 5 months ago (2016-07-25 23:06:46 UTC) #4 
https://codereview.chromium.org/2181773002/diff/1/net/quic/test_tools/crypto_...
File net/quic/test_tools/crypto_test_utils_test.cc (right):

https://codereview.chromium.org/2181773002/diff/1/net/quic/test_tools/crypto_...
net/quic/test_tools/crypto_test_utils_test.cc:1: #include
"net/quic/test_tools/crypto_test_utils.h"
On 2016/07/25 22:33:48, Zhongyi Shi wrote:
> Add the license header?

Done in final.

Powered by Google App Engine
This is Rietveld 408576698