net/quic/quic_server_session_base_test.cc - Issue 2183493002: Add a merely pass-through QuicMultipathSentPacketManager. Protected behind blocked flag FLAGS_quic_…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_server_session_base_test.cc

Issue 2183493002: Add a merely pass-through QuicMultipathSentPacketManager. Protected behind blocked flag FLAGS_quic_… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/quic/quic_multipath_sent_packet_manager_test.cc ('K') | « net/quic/quic_server_session_base.cc ('k') | net/quic/quic_session_test.cc » ('j') | net/quic/test_tools/quic_multipath_sent_packet_manager_peer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/quic/quic_server_session_base_test.cc

diff --git a/net/quic/quic_server_session_base_test.cc b/net/quic/quic_server_session_base_test.cc

index 980fdb19bb1137f616594be2d49e143264183d28..0d40b471aef5e377efe5a9f39b6d2323835756bf 100644

--- a/net/quic/quic_server_session_base_test.cc

+++ b/net/quic/quic_server_session_base_test.cc

@@ -406,7 +406,6 @@ TEST_P(QuicServerSessionBaseTest, BandwidthEstimates) {

// Client has sent kBWRE connection option to trigger bandwidth resumption.

// Disable this flag because if connection uses multipath sent packet manager,

// static_cast here does not work.

- FLAGS_quic_enable_multipath = false;

QuicTagVector copt;

copt.push_back(kBWRE);

QuicConfigPeer::SetReceivedConnectionOptions(session_->config(), copt);

@@ -426,8 +425,8 @@ TEST_P(QuicServerSessionBaseTest, BandwidthEstimates) {

// Set some initial bandwidth values.

QuicSentPacketManager* sent_packet_manager =

- static_cast<QuicSentPacketManager*>(

- QuicConnectionPeer::GetSentPacketManager(session_->connection()));

+ QuicConnectionPeer::GetSentPacketManager(session_->connection(),

+ kDefaultPathId);

QuicSustainedBandwidthRecorder& bandwidth_recorder =

QuicSentPacketManagerPeer::GetBandwidthRecorder(sent_packet_manager);

// Seed an rtt measurement equal to the initial default rtt.