Split fpdfdoc/include/fpdf_doc.h into individual classes.

Split fpdfdoc/include/fpdf_doc.h into individual classes.

This CL splits the header file apart. The cpp files are not touched as part
of this CL, they will be done as a followup. This de-duplicates the fpdf_doc.h

BUG=pdfium:249
Committed: https://pdfium.googlesource.com/pdfium/+/cac704dd3e5c0e5900e898db4eff5a0948cef6fc

[dsinclair, 2016-07-27 19:00:16]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 19:00:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 19:06:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 19:06:18]

Dry run: Try jobs failed on following builders:
  linux on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux/builds/1456)

[dsinclair, 2016-07-27 19:19:13]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 19:19:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-07-27 19:28:31]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, weili@chromium.org

[dsinclair, 2016-07-27 19:28:32]

PTAL.

[commit-bot: I haz the power, 2016-07-27 19:45:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 19:45:37]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-07-28 13:34:11]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 13:34:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 13:48:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 13:48:50]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-07-28 19:27:02]

https://codereview.chromium.org/2183313004/diff/40001/core/fpdfdoc/cpdf_apset...
File core/fpdfdoc/cpdf_apsettings.h (right):

https://codereview.chromium.org/2183313004/diff/40001/core/fpdfdoc/cpdf_apset...
core/fpdfdoc/cpdf_apsettings.h:1: // Copyright 2016 PDFium Authors. All rights
reserved.
Refresh my memory - the headers not in include/ are "private" ?

https://codereview.chromium.org/2183313004/diff/40001/fpdfsdk/javascript/Icon.h
File fpdfsdk/javascript/Icon.h (right):

https://codereview.chromium.org/2183313004/diff/40001/fpdfsdk/javascript/Icon...
fpdfsdk/javascript/Icon.h:12: class CPDF_Stream;
BTW, did you know the Google C++ style guide changed at some point to say don't
bother with forward decls?
https://google.github.io/styleguide/cppguide.html#Forward_Declarations

Shall we try to start following this for new code?

It does mean more files to rebuild when changing headers, but it feels like
that's less of a concern with distributed builds and -j500.

https://codereview.chromium.org/2183313004/diff/40001/fpdfsdk/javascript/Icon...
fpdfsdk/javascript/Icon.h:16: Icon(CJS_Object* pJSObject);
explicit here and line 32.

[Lei Zhang, 2016-07-28 19:27:59]

lgtm

[dsinclair, 2016-07-28 19:42:15]

https://codereview.chromium.org/2183313004/diff/40001/core/fpdfdoc/cpdf_apset...
File core/fpdfdoc/cpdf_apsettings.h (right):

https://codereview.chromium.org/2183313004/diff/40001/core/fpdfdoc/cpdf_apset...
core/fpdfdoc/cpdf_apsettings.h:1: // Copyright 2016 PDFium Authors. All rights
reserved.
On 2016/07/28 19:27:02, Lei Zhang wrote:
> Refresh my memory - the headers not in include/ are "private" ?

If a header is in include/ it can be included from other top level folders (like
xfa/ and fpdfsdk/) if it isn't in an include/ directory it can only be included
from other files in the same top level folder (so this is only visible to things
in core/)

https://codereview.chromium.org/2183313004/diff/40001/fpdfsdk/javascript/Icon.h
File fpdfsdk/javascript/Icon.h (right):

https://codereview.chromium.org/2183313004/diff/40001/fpdfsdk/javascript/Icon...
fpdfsdk/javascript/Icon.h:12: class CPDF_Stream;
On 2016/07/28 19:27:02, Lei Zhang wrote:
> BTW, did you know the Google C++ style guide changed at some point to say
don't
> bother with forward decls?
> https://google.github.io/styleguide/cppguide.html#Forward_Declarations
> 
> Shall we try to start following this for new code?
> 
> It does mean more files to rebuild when changing headers, but it feels like
> that's less of a concern with distributed builds and -j500.


Switching is probably a good idea for new code, didn't realize the style guide
said not to use them.

I'll leave the ones I have from this patch series, but will use includes in the
future.

https://codereview.chromium.org/2183313004/diff/40001/fpdfsdk/javascript/Icon...
fpdfsdk/javascript/Icon.h:16: Icon(CJS_Object* pJSObject);
On 2016/07/28 19:27:02, Lei Zhang wrote:
> explicit here and line 32.

Done.

[dsinclair, 2016-07-28 19:42:30]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-07-28 19:42:31]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2183313004/#ps60001
(title: "review feedback")

[commit-bot: I haz the power, 2016-07-28 19:42:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 19:59:14]

Description was changed from

==========
Split fpdfdoc/include/fpdf_doc.h into individual classes.

This CL splits the header file apart. The cpp files are not touched as part
of this CL, they will be done as a followup. This de-duplicates the fpdf_doc.h

BUG=pdfium:249
==========

to

==========
Split fpdfdoc/include/fpdf_doc.h into individual classes.

This CL splits the header file apart. The cpp files are not touched as part
of this CL, they will be done as a followup. This de-duplicates the fpdf_doc.h

BUG=pdfium:249

Committed:
https://pdfium.googlesource.com/pdfium/+/cac704dd3e5c0e5900e898db4eff5a0948ce...
==========

[commit-bot: I haz the power, 2016-07-28 19:59:15]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/cac704dd3e5c0e5900e898db4eff5a0948ce...

[Lei Zhang, 2016-08-16 04:48:45]

https://codereview.chromium.org/2183313004/diff/40001/fpdfsdk/javascript/Icon.h
File fpdfsdk/javascript/Icon.h (right):

https://codereview.chromium.org/2183313004/diff/40001/fpdfsdk/javascript/Icon...
fpdfsdk/javascript/Icon.h:12: class CPDF_Stream;
On 2016/07/28 19:42:14, dsinclair wrote:
> On 2016/07/28 19:27:02, Lei Zhang wrote:
> > BTW, did you know the Google C++ style guide changed at some point to say
> don't
> > bother with forward decls?
> > https://google.github.io/styleguide/cppguide.html#Forward_Declarations
> > 
> > Shall we try to start following this for new code?
> > 
> > It does mean more files to rebuild when changing headers, but it feels like
> > that's less of a concern with distributed builds and -j500.
> 
> 
> Switching is probably a good idea for new code, didn't realize the style guide
> said not to use them.
> 
> I'll leave the ones I have from this patch series, but will use includes in
the
> future.

And I missed the memo on the Chromium style guide override. :\
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...