Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2188213002: Remove the document tagged code as it is unused. (Closed)

Created:
4 years, 4 months ago by dsinclair
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang, npm, Wei Li
CC:
pdfium-reviews_googlegroups.com, npm
Base URL:
https://pdfium.googlesource.com/pdfium.git@fpdf_doc
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove the document tagged code as it is unused. The fpdf_tagged.h, tagged_int.h and doc_tagged.cpp code is currently unused and can be removed. Committed: https://pdfium.googlesource.com/pdfium/+/dbfc3522a6ee24d17f2c50a5dcc465db52a280ee

Patch Set 1 #

Patch Set 2 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -665 lines) Patch
M BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D core/fpdfdoc/doc_tagged.cpp View 1 chunk +0 lines, -459 lines 0 comments Download
D core/fpdfdoc/include/fpdf_tagged.h View 1 chunk +0 lines, -93 lines 0 comments Download
D core/fpdfdoc/tagged_int.h View 1 chunk +0 lines, -107 lines 0 comments Download
M pdfium.gyp View 2 chunks +0 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (9 generated)
dsinclair
PTAL.
4 years, 4 months ago (2016-07-28 13:54:24 UTC) #4
Lei Zhang
lgtm There's ~80 pages of PDF spec dedicated to Logical Structure (including StructTreeRoot) and Tagged ...
4 years, 4 months ago (2016-07-28 19:35:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188213002/20001
4 years, 4 months ago (2016-07-28 19:59:40 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://pdfium.googlesource.com/pdfium/+/dbfc3522a6ee24d17f2c50a5dcc465db52a280ee
4 years, 4 months ago (2016-07-28 20:17:33 UTC) #12
npm
This code is being used by the android foxit viewer. Should we revert this CL?
4 years, 3 months ago (2016-08-25 22:49:17 UTC) #14
Lei Zhang
On 2016/08/25 22:49:17, npm wrote: > This code is being used by the android foxit ...
4 years, 3 months ago (2016-08-25 22:55:57 UTC) #15
npm
No internal bug that I'm aware of, just tried upgrading pdfium in google3 and building ...
4 years, 3 months ago (2016-08-26 14:33:17 UTC) #16
npm
4 years, 3 months ago (2016-08-26 16:55:17 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2279323002/ by npm@chromium.org.

The reason for reverting is: Code being used by Android foxit viewer.

Powered by Google App Engine
This is Rietveld 408576698