Split fpdfdoc/include/fpdf_doc.h into individual classes.

fpdfsdk/javascript/Icon.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef FPDFSDK_JAVASCRIPT_ICON_H_
 #define FPDFSDK_JAVASCRIPT_ICON_H_
 
 #include "fpdfsdk/javascript/JS_Define.h"
 
+class CPDF_Stream;

[Lei Zhang, 2016/07/28 19:27:02]

BTW, did you know the Google C++ style guide changed at some point to say don't
bother with forward decls?
https://google.github.io/styleguide/cppguide.html#Forward_Declarations

Shall we try to start following this for new code?

It does mean more files to rebuild when changing headers, but it feels like
that's less of a concern with distributed builds and -j500.

[dsinclair, 2016/07/28 19:42:14]

Switching is probably a good idea for new code, didn't realize the style guide
said not to use them.

I'll leave the ones I have from this patch series, but will use includes in the
future.

[Lei Zhang, 2016/08/16 04:48:45]

And I missed the memo on the Chromium style guide override. :\
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...

+
 class Icon : public CJS_EmbedObj {
  public:
   Icon(CJS_Object* pJSObject);

[Lei Zhang, 2016/07/28 19:27:02]

explicit here and line 32.

[dsinclair, 2016/07/28 19:42:14]

Done.

   ~Icon() override;
 
   FX_BOOL name(IJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError);
   void SetStream(CPDF_Stream* pIconStream);
   CPDF_Stream* GetStream();
   void SetIconName(CFX_WideString name);
   CFX_WideString GetIconName();
 
  private:
   CPDF_Stream* m_pIconStream;
   CFX_WideString m_swIconName;
 };
 
 class CJS_Icon : public CJS_Object {
  public:
   CJS_Icon(v8::Local<v8::Object> pObject) : CJS_Object(pObject) {}
   ~CJS_Icon() override {}
 
   DECLARE_JS_CLASS();
   JS_STATIC_PROP(name, Icon);
 };
 
 #endif  // FPDFSDK_JAVASCRIPT_ICON_H_