Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 218313002: Revert of Put the squashing layer underneath the ancestor clipping layer if present. (Closed)

Created:
6 years, 8 months ago by Ian Vollick
Modified:
6 years, 8 months ago
Reviewers:
chrishtr, hartmanng
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, jchaffraix+rendering, pdr., rune+blink
Visibility:
Public.

Description

Revert of Put the squashing layer underneath the ancestor clipping layer if present. (https://codereview.chromium.org/215823002/) Reason for revert: This appears to have unexpected effects on rendering. Bits of gmail are missing for example. Original issue's description: > Put the squashing layer underneath the ancestor clipping layer if present. > > Previously, this was the case for m_graphicsLayer but not m_squashingLayer. > Since they now are guaranteed to have the same clipping ancestor, this is both > safe and correct. > > BUG=336563 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170348 TBR=hartmanng@chromium.org,chrishtr@chromium.org NOTREECHECKS=true NOTRY=true BUG=336563 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170413

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -153 lines) Patch
D LayoutTests/compositing/squashing/overflow-scroll-grandchildren.html View 1 chunk +0 lines, -62 lines 0 comments Download
D LayoutTests/compositing/squashing/overflow-scroll-grandchildren-expected.html View 1 chunk +0 lines, -57 lines 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 3 chunks +16 lines, -20 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ian Vollick
Created Revert of Put the squashing layer underneath the ancestor clipping layer if present.
6 years, 8 months ago (2014-03-29 09:35:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/218313002/1
6 years, 8 months ago (2014-03-29 09:35:19 UTC) #2
commit-bot: I haz the power
Change committed as 170413
6 years, 8 months ago (2014-03-29 09:35:36 UTC) #3
chrishtr
FYI I'm not able to repro the break described here so far on Linux Aura.
6 years, 8 months ago (2014-03-31 17:34:30 UTC) #4
chrishtr
6 years, 8 months ago (2014-04-01 03:05:03 UTC) #5
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/219223008/ by chrishtr@chromium.org.

The reason for reverting is: The breakage is only with
--enable-universal-accelerated-overflow-scroll true. Since that feature is not
launched and not tied to squashing, going to re-lad the original CL..

Powered by Google App Engine
This is Rietveld 408576698