Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2182973002: Revert of Disable A Few More AppBannerDataFetcherBrowserTest Failing Tests (Closed)

Created:
4 years, 4 months ago by dominickn
Modified:
4 years, 4 months ago
Reviewers:
Mark P
CC:
chromium-reviews, dominickn+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable A Few More AppBannerDataFetcherBrowserTest Failing Tests (patchset #1 id:1 of https://codereview.chromium.org/2183743002/ ) Reason for revert: These test failures were caused by a bug in https://codereview.chromium.org/2181553003/ Re-enabling. Original issue's description: > Disable A Few More AppBannerDataFetcherBrowserTest Failing Tests > > I didn't see these failures in the original lists I checked. > > TBR=dominickn@chromium.org > > BUG=631190 > > Committed: https://crrev.com/8945bfac334ff9b1ec226e158a1f29e3fdce5e0c > Cr-Commit-Position: refs/heads/master@{#407707} TBR=mpearson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=631190 Committed: https://crrev.com/3d1d8ade55ffbe65c1b4dfe399b8ef42a196c377 Cr-Commit-Position: refs/heads/master@{#407745}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -24 lines) Patch
M chrome/browser/banners/app_banner_data_fetcher_browsertest.cc View 3 chunks +5 lines, -24 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dominickn
Created Revert of Disable A Few More AppBannerDataFetcherBrowserTest Failing Tests
4 years, 4 months ago (2016-07-26 09:15:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182973002/1
4 years, 4 months ago (2016-07-26 09:15:53 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 09:16:32 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 09:18:33 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d1d8ade55ffbe65c1b4dfe399b8ef42a196c377
Cr-Commit-Position: refs/heads/master@{#407745}

Powered by Google App Engine
This is Rietveld 408576698