Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Side by Side Diff: chrome/browser/banners/app_banner_data_fetcher_browsertest.cc

Issue 2182973002: Revert of Disable A Few More AppBannerDataFetcherBrowserTest Failing Tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/banners/app_banner_data_fetcher.h" 5 #include "chrome/browser/banners/app_banner_data_fetcher.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/location.h" 8 #include "base/location.h"
9 #include "base/run_loop.h" 9 #include "base/run_loop.h"
10 #include "base/single_thread_task_runner.h" 10 #include "base/single_thread_task_runner.h"
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 #else 160 #else
161 #define MAYBE_WebAppBannerCreatedDirectLargerTotal WebAppBannerCreatedDirectLarg erTotal 161 #define MAYBE_WebAppBannerCreatedDirectLargerTotal WebAppBannerCreatedDirectLarg erTotal
162 #endif 162 #endif
163 IN_PROC_BROWSER_TEST_F(AppBannerDataFetcherBrowserTest, 163 IN_PROC_BROWSER_TEST_F(AppBannerDataFetcherBrowserTest,
164 MAYBE_WebAppBannerCreatedDirectLargerTotal) { 164 MAYBE_WebAppBannerCreatedDirectLargerTotal) {
165 AppBannerSettingsHelper::SetTotalEngagementToTrigger(4); 165 AppBannerSettingsHelper::SetTotalEngagementToTrigger(4);
166 RunBannerTest("/banners/manifest_test_page.html", ui::PAGE_TRANSITION_TYPED, 166 RunBannerTest("/banners/manifest_test_page.html", ui::PAGE_TRANSITION_TYPED,
167 3, true); 167 3, true);
168 } 168 }
169 169
170 // http://crbug.com/631190
171 #if defined(OS_WIN)
172 #define MAYBE_WebAppBannerCreatedDirectSmallerTotal DISABLED_WebAppBannerCreated DirectSmallerTotal
173 #else
174 #define MAYBE_WebAppBannerCreatedDirectSmallerTotal WebAppBannerCreatedDirectSma llerTotal
175 #endif
176 IN_PROC_BROWSER_TEST_F(AppBannerDataFetcherBrowserTest, 170 IN_PROC_BROWSER_TEST_F(AppBannerDataFetcherBrowserTest,
177 MAYBE_WebAppBannerCreatedDirectSmallerTotal) { 171 WebAppBannerCreatedDirectSmallerTotal) {
178 AppBannerSettingsHelper::SetTotalEngagementToTrigger(1); 172 AppBannerSettingsHelper::SetTotalEngagementToTrigger(1);
179 RunBannerTest("/banners/manifest_test_page.html", ui::PAGE_TRANSITION_TYPED, 173 RunBannerTest("/banners/manifest_test_page.html", ui::PAGE_TRANSITION_TYPED,
180 0, true); 174 0, true);
181 } 175 }
182 176
183 // http://crbug.com/631190 177 // http://crbug.com/631190
184 #if defined(OS_WIN) 178 #if defined(OS_WIN)
185 #define MAYBE_WebAppBannerCreatedDirectSingle DISABLED_WebAppBannerCreatedDirect Single 179 #define MAYBE_WebAppBannerCreatedDirectSingle DISABLED_WebAppBannerCreatedDirect Single
186 #else 180 #else
187 #define MAYBE_WebAppBannerCreatedDirectSingle WebAppBannerCreatedDirectSingle 181 #define MAYBE_WebAppBannerCreatedDirectSingle WebAppBannerCreatedDirectSingle
(...skipping 25 matching lines...) Expand all
213 #define MAYBE_WebAppBannerCreatedDirectMultipleLargerTotal WebAppBannerCreatedDi rectMultipleLargerTotal 207 #define MAYBE_WebAppBannerCreatedDirectMultipleLargerTotal WebAppBannerCreatedDi rectMultipleLargerTotal
214 #endif 208 #endif
215 IN_PROC_BROWSER_TEST_F(AppBannerDataFetcherBrowserTest, 209 IN_PROC_BROWSER_TEST_F(AppBannerDataFetcherBrowserTest,
216 MAYBE_WebAppBannerCreatedDirectMultipleLargerTotal) { 210 MAYBE_WebAppBannerCreatedDirectMultipleLargerTotal) {
217 AppBannerSettingsHelper::SetEngagementWeights(0.5, 1); 211 AppBannerSettingsHelper::SetEngagementWeights(0.5, 1);
218 AppBannerSettingsHelper::SetTotalEngagementToTrigger(3); 212 AppBannerSettingsHelper::SetTotalEngagementToTrigger(3);
219 RunBannerTest("/banners/manifest_test_page.html", 213 RunBannerTest("/banners/manifest_test_page.html",
220 ui::PAGE_TRANSITION_GENERATED, 5, true); 214 ui::PAGE_TRANSITION_GENERATED, 5, true);
221 } 215 }
222 216
223 // http://crbug.com/631190
224 #if defined(OS_WIN)
225 #define MAYBE_WebAppBannerCreatedDirectMultipleSmallerTotal DISABLED_WebAppBanne rCreatedDirectMultipleSmallerTotal
226 #else
227 #define MAYBE_WebAppBannerCreatedDirectMultipleSmallerTotal WebAppBannerCreatedD irectMultipleSmallerTotal
228 #endif
229 IN_PROC_BROWSER_TEST_F(AppBannerDataFetcherBrowserTest, 217 IN_PROC_BROWSER_TEST_F(AppBannerDataFetcherBrowserTest,
230 MAYBE_WebAppBannerCreatedDirectMultipleSmallerTotal) { 218 WebAppBannerCreatedDirectMultipleSmallerTotal) {
231 AppBannerSettingsHelper::SetEngagementWeights(0.5, 1); 219 AppBannerSettingsHelper::SetEngagementWeights(0.5, 1);
232 AppBannerSettingsHelper::SetTotalEngagementToTrigger(1); 220 AppBannerSettingsHelper::SetTotalEngagementToTrigger(1);
233 RunBannerTest("/banners/manifest_test_page.html", 221 RunBannerTest("/banners/manifest_test_page.html",
234 ui::PAGE_TRANSITION_GENERATED, 1, true); 222 ui::PAGE_TRANSITION_GENERATED, 1, true);
235 } 223 }
236 224
237 // http://crbug.com/631190 225 // http://crbug.com/631190
238 #if defined(OS_WIN) 226 #if defined(OS_WIN)
239 #define MAYBE_WebAppBannerCreatedIndirect DISABLED_WebAppBannerCreatedIndirect 227 #define MAYBE_WebAppBannerCreatedIndirect DISABLED_WebAppBannerCreatedIndirect
240 #else 228 #else
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
421 #define MAYBE_CancelBannerDirect DISABLED_CancelBannerDirect 409 #define MAYBE_CancelBannerDirect DISABLED_CancelBannerDirect
422 #else 410 #else
423 #define MAYBE_CancelBannerDirect CancelBannerDirect 411 #define MAYBE_CancelBannerDirect CancelBannerDirect
424 #endif 412 #endif
425 IN_PROC_BROWSER_TEST_F(AppBannerDataFetcherBrowserTest, 413 IN_PROC_BROWSER_TEST_F(AppBannerDataFetcherBrowserTest,
426 MAYBE_CancelBannerDirect) { 414 MAYBE_CancelBannerDirect) {
427 RunBannerTest("/banners/cancel_test_page.html", ui::PAGE_TRANSITION_TYPED, 1, 415 RunBannerTest("/banners/cancel_test_page.html", ui::PAGE_TRANSITION_TYPED, 1,
428 false); 416 false);
429 } 417 }
430 418
431 // http://crbug.com/631190 419 IN_PROC_BROWSER_TEST_F(AppBannerDataFetcherBrowserTest, CancelBannerIndirect) {
432 #if defined(OS_WIN)
433 #define MAYBE_CancelBannerIndirect DISABLED_CancelBannerIndirect
434 #else
435 #define MAYBE_CancelBannerIndirect CancelBannerIndirect
436 #endif
437 IN_PROC_BROWSER_TEST_F(AppBannerDataFetcherBrowserTest,
438 MAYBE_CancelBannerIndirect) {
439 AppBannerSettingsHelper::SetEngagementWeights(1, 0.5); 420 AppBannerSettingsHelper::SetEngagementWeights(1, 0.5);
440 RunBannerTest("/banners/cancel_test_page.html", ui::PAGE_TRANSITION_TYPED, 3, 421 RunBannerTest("/banners/cancel_test_page.html", ui::PAGE_TRANSITION_TYPED, 3,
441 false); 422 false);
442 } 423 }
443 424
444 // http://crbug.com/631190 425 // http://crbug.com/631190
445 #if defined(OS_WIN) 426 #if defined(OS_WIN)
446 #define MAYBE_PromptBanner DISABLED_PromptBanner 427 #define MAYBE_PromptBanner DISABLED_PromptBanner
447 #else 428 #else
448 #define MAYBE_PromptBanner PromptBanner 429 #define MAYBE_PromptBanner PromptBanner
(...skipping 15 matching lines...) Expand all
464 RunBannerTest("/banners/prompt_in_handler_test_page.html", 445 RunBannerTest("/banners/prompt_in_handler_test_page.html",
465 ui::PAGE_TRANSITION_TYPED, 1, true); 446 ui::PAGE_TRANSITION_TYPED, 1, true);
466 } 447 }
467 448
468 IN_PROC_BROWSER_TEST_F(AppBannerDataFetcherBrowserTest, WebAppBannerInIFrame) { 449 IN_PROC_BROWSER_TEST_F(AppBannerDataFetcherBrowserTest, WebAppBannerInIFrame) {
469 RunBannerTest("/banners/iframe_test_page.html", ui::PAGE_TRANSITION_TYPED, 1, 450 RunBannerTest("/banners/iframe_test_page.html", ui::PAGE_TRANSITION_TYPED, 1,
470 false); 451 false);
471 } 452 }
472 453
473 } // namespace banners 454 } // namespace banners
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698