Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: chrome/browser/banners/app_banner_data_fetcher_browsertest.cc

Issue 2182973002: Revert of Disable A Few More AppBannerDataFetcherBrowserTest Failing Tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/banners/app_banner_data_fetcher_browsertest.cc
diff --git a/chrome/browser/banners/app_banner_data_fetcher_browsertest.cc b/chrome/browser/banners/app_banner_data_fetcher_browsertest.cc
index 725907c2d4ef49eb7c6a0b55bfc7584a449d4327..ac46ffc598df2d529c85cc986c4ddb96b25bb4e7 100644
--- a/chrome/browser/banners/app_banner_data_fetcher_browsertest.cc
+++ b/chrome/browser/banners/app_banner_data_fetcher_browsertest.cc
@@ -167,14 +167,8 @@
3, true);
}
-// http://crbug.com/631190
-#if defined(OS_WIN)
-#define MAYBE_WebAppBannerCreatedDirectSmallerTotal DISABLED_WebAppBannerCreatedDirectSmallerTotal
-#else
-#define MAYBE_WebAppBannerCreatedDirectSmallerTotal WebAppBannerCreatedDirectSmallerTotal
-#endif
-IN_PROC_BROWSER_TEST_F(AppBannerDataFetcherBrowserTest,
- MAYBE_WebAppBannerCreatedDirectSmallerTotal) {
+IN_PROC_BROWSER_TEST_F(AppBannerDataFetcherBrowserTest,
+ WebAppBannerCreatedDirectSmallerTotal) {
AppBannerSettingsHelper::SetTotalEngagementToTrigger(1);
RunBannerTest("/banners/manifest_test_page.html", ui::PAGE_TRANSITION_TYPED,
0, true);
@@ -220,14 +214,8 @@
ui::PAGE_TRANSITION_GENERATED, 5, true);
}
-// http://crbug.com/631190
-#if defined(OS_WIN)
-#define MAYBE_WebAppBannerCreatedDirectMultipleSmallerTotal DISABLED_WebAppBannerCreatedDirectMultipleSmallerTotal
-#else
-#define MAYBE_WebAppBannerCreatedDirectMultipleSmallerTotal WebAppBannerCreatedDirectMultipleSmallerTotal
-#endif
-IN_PROC_BROWSER_TEST_F(AppBannerDataFetcherBrowserTest,
- MAYBE_WebAppBannerCreatedDirectMultipleSmallerTotal) {
+IN_PROC_BROWSER_TEST_F(AppBannerDataFetcherBrowserTest,
+ WebAppBannerCreatedDirectMultipleSmallerTotal) {
AppBannerSettingsHelper::SetEngagementWeights(0.5, 1);
AppBannerSettingsHelper::SetTotalEngagementToTrigger(1);
RunBannerTest("/banners/manifest_test_page.html",
@@ -428,14 +416,7 @@
false);
}
-// http://crbug.com/631190
-#if defined(OS_WIN)
-#define MAYBE_CancelBannerIndirect DISABLED_CancelBannerIndirect
-#else
-#define MAYBE_CancelBannerIndirect CancelBannerIndirect
-#endif
-IN_PROC_BROWSER_TEST_F(AppBannerDataFetcherBrowserTest,
- MAYBE_CancelBannerIndirect) {
+IN_PROC_BROWSER_TEST_F(AppBannerDataFetcherBrowserTest, CancelBannerIndirect) {
AppBannerSettingsHelper::SetEngagementWeights(1, 0.5);
RunBannerTest("/banners/cancel_test_page.html", ui::PAGE_TRANSITION_TYPED, 3,
false);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698