Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 2182543003: Move prepareForExternalIO from GrRenderTarget to GrDrawContext (Closed)

Created:
4 years, 4 months ago by robertphillips
Modified:
4 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move prepareForExternalIO from GrRenderTarget to GrDrawContext This is part of the push to remove GrRenderTarget from SkGpuDevice GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2182543003 Committed: https://skia.googlesource.com/skia/+/8c523e0f3ffa66eefd70f893e9f863b7d9ea3dc9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -14 lines) Patch
M include/gpu/GrDrawContext.h View 1 chunk +6 lines, -0 lines 0 comments Download
M include/gpu/GrSurface.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M src/gpu/GrSurface.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
robertphillips
4 years, 4 months ago (2016-07-26 13:05:43 UTC) #5
bsalomon
lgtm
4 years, 4 months ago (2016-07-26 13:52:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182543003/1
4 years, 4 months ago (2016-07-26 14:40:07 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 14:41:04 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8c523e0f3ffa66eefd70f893e9f863b7d9ea3dc9

Powered by Google App Engine
This is Rietveld 408576698