Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2182133002: Add next_version_mini_installer to MiniInstallerTest's compile targets. (Closed)

Created:
4 years, 4 months ago by fdoray
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Add next_version_mini_installer to MiniInstallerTest's compile targets. We plan to start using next_version_mini_installer.exe in mini_installer tests https://codereview.chromium.org/1929383002 This CL is identical to https://codereview.chromium.org/1935583002 It shouldn't be reverted this time because the 'next_version_mini_installer' target exists in all supported branches (M52+). BUG=605177 Committed: https://chromium.googlesource.com/chromium/tools/build/+/fa772cf7a2487a00eb38ff4eb7377b80f82c8b20

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -40 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/steps.py View 1 chunk +1 line, -1 line 2 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_Builder.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_skia_Win_Builder.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_skia_Win_Builder_Trybot.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/analyze_runs_nothing_with_no_source_file_changes.json View 2 chunks +3 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/analyze_webkit.json View 2 chunks +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win10_chromium_x64_rel_ng.json View 2 chunks +10 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win10_chromium_x64_rel_ng_exp.json View 2 chunks +10 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_compile_rel_ng.json View 2 chunks +10 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_rel_ng.json View 2 chunks +10 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_x64_rel_ng.json View 2 chunks +10 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/process_dumps_failure.json View 2 chunks +10 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_chromium_trybot.json View 2 chunks +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
fdoray
PTAL
4 years, 4 months ago (2016-07-26 14:05:19 UTC) #2
Dirk Pranke
https://codereview.chromium.org/2182133002/diff/1/scripts/slave/recipe_modules/chromium_tests/steps.py File scripts/slave/recipe_modules/chromium_tests/steps.py (right): https://codereview.chromium.org/2182133002/diff/1/scripts/slave/recipe_modules/chromium_tests/steps.py#newcode1646 scripts/slave/recipe_modules/chromium_tests/steps.py:1646: return ['mini_installer', 'next_version_mini_installer'] Didn't we try this once before? ...
4 years, 4 months ago (2016-07-26 18:47:52 UTC) #3
fdoray
https://codereview.chromium.org/2182133002/diff/1/scripts/slave/recipe_modules/chromium_tests/steps.py File scripts/slave/recipe_modules/chromium_tests/steps.py (right): https://codereview.chromium.org/2182133002/diff/1/scripts/slave/recipe_modules/chromium_tests/steps.py#newcode1646 scripts/slave/recipe_modules/chromium_tests/steps.py:1646: return ['mini_installer', 'next_version_mini_installer'] On 2016/07/26 18:47:51, Dirk Pranke wrote: ...
4 years, 4 months ago (2016-07-26 19:00:59 UTC) #4
Dirk Pranke
okay, great then. lgtm.
4 years, 4 months ago (2016-07-26 19:02:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182133002/1
4 years, 4 months ago (2016-07-26 19:06:19 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 19:09:39 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/fa772cf7a2487a00eb38...

Powered by Google App Engine
This is Rietveld 408576698