Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1935583002: Add next_version_mini_installer to MiniInstallerTest's compile targets. (Closed)

Created:
4 years, 7 months ago by fdoray
Modified:
4 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Add next_version_mini_installer to MiniInstallerTest's compile targets. We plan to start using next_version_mini_installer.exe in mini_installer tests https://codereview.chromium.org/1929383002 BUG=605177 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300363

Patch Set 1 #

Patch Set 2 : add expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -41 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/steps.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder.json View 1 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_Builder.json View 1 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_skia_Win_Builder.json View 1 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_skia_Win_Builder_Trybot.json View 1 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/analyze_runs_nothing_with_no_source_file_changes.json View 1 2 chunks +3 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/analyze_webkit.json View 1 2 chunks +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win10_chromium_x64_rel_ng.json View 1 2 chunks +10 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win10_chromium_x64_rel_ng_exp.json View 1 2 chunks +10 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_compile_rel_ng.json View 1 2 chunks +10 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_rel_ng.json View 1 2 chunks +10 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_x64_rel_ng.json View 1 2 chunks +10 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/process_dumps_failure.json View 1 2 chunks +10 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_chromium_trybot.json View 1 2 chunks +3 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
fdoray
Can you review this CL? Thanks.
4 years, 7 months ago (2016-04-29 17:29:25 UTC) #2
Dirk Pranke
lgtm
4 years, 7 months ago (2016-04-29 17:49:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935583002/1
4 years, 7 months ago (2016-04-29 17:51:01 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/4541)
4 years, 7 months ago (2016-04-29 17:59:12 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935583002/20001
4 years, 7 months ago (2016-04-29 18:24:04 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-29 18:27:35 UTC) #11
fdoray
dpranke@: I updated files in scripts/slave/recipes/chromium.expected/* and scripts/slave/recipes/chromium_trybot.expected/*. Do I still have your lgtm?
4 years, 7 months ago (2016-04-29 18:28:26 UTC) #12
Dirk Pranke
still lgtm.
4 years, 7 months ago (2016-04-29 18:57:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935583002/20001
4 years, 7 months ago (2016-04-29 18:58:40 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=300363
4 years, 7 months ago (2016-04-29 19:02:38 UTC) #17
Dirk Pranke
4 years, 7 months ago (2016-04-29 23:36:09 UTC) #18
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1934033002/ by dpranke@chromium.org.

The reason for reverting is: Unfortunately, I need to revert this because it
breaks one of the internal builders.

See the details in crbug.com/608066..

Powered by Google App Engine
This is Rietveld 408576698