Add mini_installer not-in-use update test.

Add mini_installer not-in-use update test.

The new tests install Chrome at the user level, system level or SxS
and update it. They then verifies that files have been written as
expected.

BUG=605177
Committed: https://crrev.com/fc0191e67db955f788ce61a5d4f832271ff102d4
Cr-Commit-Position: refs/heads/master@{#409635}

[fdoray, 2016-04-29 17:28:43]

fdoray@chromium.org changed reviewers:
+ grt@chromium.org

[fdoray, 2016-04-29 17:28:44]

Can you review this CL? It depends on
https://codereview.chromium.org/1935583002/
Thanks!

[grt (UTC plus 2), 2016-04-30 00:55:53]

uncomfortably excited!

https://codereview.chromium.org/1929383002/diff/20001/chrome/test/mini_instal...
File chrome/test/mini_installer/config/chrome_user_updated.prop (right):

https://codereview.chromium.org/1929383002/diff/20001/chrome/test/mini_instal...
chrome/test/mini_installer/config/chrome_user_updated.prop:20: "pv": {"type":
"SZ", "data": "$NEXT_VERSION_MINI_INSTALLER_FILE_VERSION"}
this is for testing a non-in-use update, correct? please assert that 'opv' and
'cmd' are not present in the registry (these two values are present when an
in-use update is applied). i think this is true for the BINARIES subkey as well;
please check the code (or try it out) to be sure.

https://codereview.chromium.org/1929383002/diff/20001/chrome/test/mini_instal...
File chrome/test/mini_installer/config/config.config (right):

https://codereview.chromium.org/1929383002/diff/20001/chrome/test/mini_instal...
chrome/test/mini_installer/config/config.config:73:
"\"$NEXT_VERSION_MINI_INSTALLER\" --chrome --multi-install --verbose-logging
--do-not-launch-chrome"],
please remove --chrome from the command line to more closely match what is used
in production. "--multi-install" by itself is tells the installer "hey, update
all multi-install products at once".

https://codereview.chromium.org/1929383002/diff/20001/chrome/test/mini_instal...
chrome/test/mini_installer/config/config.config:107: "name":
"ChromeUserLevelUpdate",
please add a system-level complement to this.

[fdoray, 2016-08-01 14:50:33]

PTAnL

https://codereview.chromium.org/1929383002/diff/20001/chrome/test/mini_instal...
File chrome/test/mini_installer/config/chrome_user_updated.prop (right):

https://codereview.chromium.org/1929383002/diff/20001/chrome/test/mini_instal...
chrome/test/mini_installer/config/chrome_user_updated.prop:20: "pv": {"type":
"SZ", "data": "$NEXT_VERSION_MINI_INSTALLER_FILE_VERSION"}
On 2016/04/30 00:55:53, grt (UTC plus 2) wrote:
> this is for testing a non-in-use update, correct? please assert that 'opv' and
> 'cmd' are not present in the registry (these two values are present when an
> in-use update is applied). i think this is true for the BINARIES subkey as
well;
> please check the code (or try it out) to be sure.

In-use update:
 CHROME subkey: pv, opv, cmd exist
 BINARIES subkey: pv, opv exist
 LAUNCHER subkey: pv exists
Non-in-use update:
 CHROME subkey: pv exists
 BINARIES subkey: pv exists
 LAUNCHER subkey: pv exists

I modified the test to verify that opv and cmd don't exist for the CHROME and
BINARIES subkeys. Maybe verifying that cmd doesn't exist for the BINARIES subkey
is overkill, but it's not invalid and could catch regressions.

https://codereview.chromium.org/1929383002/diff/20001/chrome/test/mini_instal...
File chrome/test/mini_installer/config/config.config (right):

https://codereview.chromium.org/1929383002/diff/20001/chrome/test/mini_instal...
chrome/test/mini_installer/config/config.config:73:
"\"$NEXT_VERSION_MINI_INSTALLER\" --chrome --multi-install --verbose-logging
--do-not-launch-chrome"],
On 2016/04/30 00:55:53, grt (UTC plus 2) wrote:
> please remove --chrome from the command line to more closely match what is
used
> in production. "--multi-install" by itself is tells the installer "hey, update
> all multi-install products at once".

Done.

https://codereview.chromium.org/1929383002/diff/20001/chrome/test/mini_instal...
chrome/test/mini_installer/config/config.config:107: "name":
"ChromeUserLevelUpdate",
On 2016/04/30 00:55:53, grt (UTC plus 2) wrote:
> please add a system-level complement to this.

Done.

[fdoray, 2016-08-01 14:51:13]

Description was changed from

==========
Add mini_installer update test.

The ChromeUserLevelUpdate test installs Chrome at the user level and
updates it. It then verifies that files have been written as expected.

BUG=605177
==========

to

==========
Add mini_installer not-in-use update test.

The ChromeUserLevelUpdate test installs Chrome at the user level and
updates it. It then verifies that files have been written as expected.

The ChromeSystemLevelUpdate test does the same thing at the system
level.

BUG=605177
==========

[grt (UTC plus 2), 2016-08-01 15:08:16]

https://codereview.chromium.org/1929383002/diff/20001/chrome/test/mini_instal...
File chrome/test/mini_installer/config/chrome_user_updated.prop (right):

https://codereview.chromium.org/1929383002/diff/20001/chrome/test/mini_instal...
chrome/test/mini_installer/config/chrome_user_updated.prop:20: "pv": {"type":
"SZ", "data": "$NEXT_VERSION_MINI_INSTALLER_FILE_VERSION"}
On 2016/08/01 14:50:33, fdoray wrote:
> On 2016/04/30 00:55:53, grt (UTC plus 2) wrote:
> > this is for testing a non-in-use update, correct? please assert that 'opv'
and
> > 'cmd' are not present in the registry (these two values are present when an
> > in-use update is applied). i think this is true for the BINARIES subkey as
> well;
> > please check the code (or try it out) to be sure.
> 
> In-use update:
>  CHROME subkey: pv, opv, cmd exist
>  BINARIES subkey: pv, opv exist
>  LAUNCHER subkey: pv exists
> Non-in-use update:
>  CHROME subkey: pv exists
>  BINARIES subkey: pv exists
>  LAUNCHER subkey: pv exists
> 
> I modified the test to verify that opv and cmd don't exist for the CHROME and
> BINARIES subkeys. Maybe verifying that cmd doesn't exist for the BINARIES
subkey
> is overkill, but it's not invalid and could catch regressions.

Acknowledged.

https://codereview.chromium.org/1929383002/diff/60001/chrome/test/mini_instal...
File chrome/test/mini_installer/config/config.config (right):

https://codereview.chromium.org/1929383002/diff/60001/chrome/test/mini_instal...
chrome/test/mini_installer/config/config.config:7:
"chrome_user_not_updated.prop",
since this is a pure subset of what chrome_user_not_installed.prop asserts, it
isn't needed here or any of the other places where not_updated immediately
follows a not_installed.

[fdoray, 2016-08-01 15:53:13]

PTAnL

https://codereview.chromium.org/1929383002/diff/60001/chrome/test/mini_instal...
File chrome/test/mini_installer/config/config.config (right):

https://codereview.chromium.org/1929383002/diff/60001/chrome/test/mini_instal...
chrome/test/mini_installer/config/config.config:7:
"chrome_user_not_updated.prop",
On 2016/08/01 15:08:16, grt (UTC plus 2) wrote:
> since this is a pure subset of what chrome_user_not_installed.prop asserts, it
> isn't needed here or any of the other places where not_updated immediately
> follows a not_installed.

Done.

[grt (UTC plus 2), 2016-08-01 20:52:09]

https://codereview.chromium.org/1929383002/diff/80001/chrome/test/mini_instal...
File chrome/test/mini_installer/config/chrome_system_not_updated.prop (right):

https://codereview.chromium.org/1929383002/diff/80001/chrome/test/mini_instal...
chrome/test/mini_installer/config/chrome_system_not_updated.prop:3:
"$PROGRAM_FILES\\$CHROME_DIR\\Application\\$NEXT_VERSION_MINI_INSTALLER_FILE_VERSION":
Pardon if this is a silly idea, but what do you think of simplifying further by
putting this into the "installed" prop file so that this can go away altogether?

[fdoray, 2016-08-02 15:20:00]

Description was changed from

==========
Add mini_installer not-in-use update test.

The ChromeUserLevelUpdate test installs Chrome at the user level and
updates it. It then verifies that files have been written as expected.

The ChromeSystemLevelUpdate test does the same thing at the system
level.

BUG=605177
==========

to

==========
Add mini_installer not-in-use update test.

The new tests install Chrome at the user level, system level or SxS
and update it. They then verifies that files have been written as
expected.

BUG=605177
==========

[fdoray, 2016-08-03 18:43:15]

PTAnL

https://codereview.chromium.org/1929383002/diff/80001/chrome/test/mini_instal...
File chrome/test/mini_installer/config/chrome_system_not_updated.prop (right):

https://codereview.chromium.org/1929383002/diff/80001/chrome/test/mini_instal...
chrome/test/mini_installer/config/chrome_system_not_updated.prop:3:
"$PROGRAM_FILES\\$CHROME_DIR\\Application\\$NEXT_VERSION_MINI_INSTALLER_FILE_VERSION":
On 2016/08/01 20:52:09, grt (UTC plus 2) wrote:
> Pardon if this is a silly idea, but what do you think of simplifying further
by
> putting this into the "installed" prop file so that this can go away
altogether?

Done.

[grt (UTC plus 2), 2016-08-03 20:40:58]

nice! lgtm.

[fdoray, 2016-08-03 20:43:57]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-08-03 20:44:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 21:59:26]

Description was changed from

==========
Add mini_installer not-in-use update test.

The new tests install Chrome at the user level, system level or SxS
and update it. They then verifies that files have been written as
expected.

BUG=605177
==========

to

==========
Add mini_installer not-in-use update test.

The new tests install Chrome at the user level, system level or SxS
and update it. They then verifies that files have been written as
expected.

BUG=605177
==========

[commit-bot: I haz the power, 2016-08-03 21:59:27]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-08-03 22:01:03]

Description was changed from

==========
Add mini_installer not-in-use update test.

The new tests install Chrome at the user level, system level or SxS
and update it. They then verifies that files have been written as
expected.

BUG=605177
==========

to

==========
Add mini_installer not-in-use update test.

The new tests install Chrome at the user level, system level or SxS
and update it. They then verifies that files have been written as
expected.

BUG=605177

Committed: https://crrev.com/fc0191e67db955f788ce61a5d4f832271ff102d4
Cr-Commit-Position: refs/heads/master@{#409635}
==========

[commit-bot: I haz the power, 2016-08-03 22:01:04]

Patchset 7 (id:??) landed as
https://crrev.com/fc0191e67db955f788ce61a5d4f832271ff102d4
Cr-Commit-Position: refs/heads/master@{#409635}