Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 21813010: Replace BIT_NOT by XOR with ~0 (Closed)

Created:
7 years, 4 months ago by weiliang.lin2
Modified:
7 years, 4 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Replace BIT_NOT by XOR with ~0 Remove the whole UnaryOp stuff as https://codereview.chromium.org/21782002

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -405 lines) Patch
M src/arm/code-stubs-arm.cc View 1 1 chunk +0 lines, -11 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 1 chunk +0 lines, -20 lines 0 comments Download
M src/ast.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/ast.cc View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M src/builtins.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/code-stubs.h View 1 2 chunks +0 lines, -68 lines 0 comments Download
M src/code-stubs.cc View 1 2 2 chunks +0 lines, -81 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 1 chunk +0 lines, -39 lines 0 comments Download
M src/full-codegen.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/hydrogen.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/hydrogen.cc View 1 3 chunks +0 lines, -23 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 1 chunk +0 lines, -11 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 1 chunk +0 lines, -19 lines 0 comments Download
M src/ic.h View 1 2 chunks +0 lines, -9 lines 0 comments Download
M src/ic.cc View 1 1 chunk +0 lines, -21 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 1 chunk +0 lines, -11 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 1 chunk +0 lines, -20 lines 0 comments Download
M src/parser.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M src/runtime.js View 1 1 chunk +0 lines, -7 lines 0 comments Download
M src/type-info.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/type-info.cc View 1 1 chunk +0 lines, -11 lines 0 comments Download
M src/typing.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 1 chunk +0 lines, -11 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
weiliang.lin2
7 years, 4 months ago (2013-08-05 06:54:44 UTC) #1
Sven Panne
This CL is missing something: In HOptimizedGraphBuilder::BuildBinaryOperation we want to transform an BIT_XOR with a ...
7 years, 4 months ago (2013-08-05 07:15:14 UTC) #2
Sven Panne
... and one more organizational remark I forgot in me previous reply: It would be ...
7 years, 4 months ago (2013-08-05 07:17:04 UTC) #3
Sven Panne
Hmmm, the CL is not even compiling. I'll open a clean new CL...
7 years, 4 months ago (2013-08-05 07:30:23 UTC) #4
weiliang.lin2
On 2013/08/05 07:30:23, Sven Panne wrote: > Hmmm, the CL is not even compiling. I'll ...
7 years, 4 months ago (2013-08-05 07:54:38 UTC) #5
weiliang.lin2
7 years, 4 months ago (2013-08-05 08:00:24 UTC) #6
On 2013/08/05 07:54:38, weiliang.lin2 wrote:
> On 2013/08/05 07:30:23, Sven Panne wrote:
> > Hmmm, the CL is not even compiling. I'll open a clean new CL...
> 
> Hi Sven, 
> Sorry for that duplicated work.in future i will give a claim before I start to
> do it. 
> 
> So, if you have your CL ready, please submit it and just close mine. It seems
my
> uploaded code is not incomplete. Weird~

The patch set 3 is OK

Powered by Google App Engine
This is Rietveld 408576698