Issue 21782002: Replaced unary negation by multiplication with -1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21782002: Replaced unary negation by multiplication with -1. (Closed)

Created:
7 years, 4 months ago by Sven Panne

Modified:
7 years, 4 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Replaced unary negation by multiplication with -1. This fixes a deopt loop in the Epic Citadel demo and removes some code. Apart from that, this change is performance-neutral. When we do something similar for BIT_NOT, the whole UnaryOp stuff can go away. R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16029

Patch Set 1 #

Patch Set 2 : Added some ASSERTs to make it explicit that only BIT_NOT is left. #

Patch Set 3 : Added test #

Patch Set 4 : Fix for --stress-opt #

Patch Set 5 : rebased #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -95 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	1 2	2 chunks	+1 line, -4 lines	0 comments	Download
M	src/code-stubs-hydrogen.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/hydrogen.cc	View	1 2 3 4	3 chunks	+4 lines, -33 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	1 2	2 chunks	+1 line, -4 lines	0 comments	Download
M	src/mips/full-codegen-mips.cc	View	1 2	2 chunks	+1 line, -4 lines	0 comments	Download
M	src/parser.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/typing.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	1 2	2 chunks	+1 line, -4 lines	0 comments	Download
A +	test/mjsunit/unary-minus-deopt.js	View	1 2 3	1 chunk	+24 lines, -39 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

7 years, 4 months ago (2013-08-02 11:56:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #5 manually as r16029 (presubmit successful).

Expand Messages | Collapse Messages