Use DCHECK instead of ASSERT in DataConsumerHandle-related stuff

Use DCHECK instead of ASSERT in DataConsumerHandle-related stuff

Committed: https://crrev.com/b2ed8e370f659625f435d414cfc0cce5aadadedf
Cr-Commit-Position: refs/heads/master@{#407799}

[tzik, 2016-07-26 09:09:20]

tzik@chromium.org changed reviewers:
+ yhirano@chromium.org

[tzik, 2016-07-26 09:09:21]

PTAL

[tzik, 2016-07-26 09:11:43]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 09:12:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-07-26 09:15:56]

On 2016/07/26 09:09:21, tzik wrote:
> PTAL

Do you want to replace assertions in all related files? Then there are more
files. Otherwise, please tell me why you chose these files.

[tzik, 2016-07-26 09:22:43]

On 2016/07/26 09:15:56, yhirano wrote:
> On 2016/07/26 09:09:21, tzik wrote:
> > PTAL
> 
> Do you want to replace assertions in all related files? Then there are more
> files. Otherwise, please tell me why you chose these files.

I'm modifying these files in a following CL, though a presubmit script complains
we must use DCHECK when I'm about to upload them.
This CL is to make the following CL less noisy.

[yhirano, 2016-07-26 09:28:46]

https://codereview.chromium.org/2181213003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.cpp
(right):

https://codereview.chromium.org/2181213003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.cpp:40: #if
DCHECK_IS_ON()
I'm not sure what this #if directive is doing. Can you explain?

ditto below.

https://codereview.chromium.org/2181213003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.cpp:208: #if
DCHECK_IS_ON()
I'm not sure what this #if directive is doing. Can you explain?

https://codereview.chromium.org/2181213003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.h
(right):

https://codereview.chromium.org/2181213003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.h:40: #if
ENABLE(ASSERT)
This should be fixed.

[tzik, 2016-07-26 09:31:31]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 09:31:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2016-07-26 09:36:06]

https://codereview.chromium.org/2181213003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.cpp
(right):

https://codereview.chromium.org/2181213003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.cpp:40: #if
DCHECK_IS_ON()
On 2016/07/26 09:28:46, yhirano wrote:
> I'm not sure what this #if directive is doing. Can you explain?
> 
> ditto below.

Oops, no it's not needed. Removed.

https://codereview.chromium.org/2181213003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.cpp:208: #if
DCHECK_IS_ON()
On 2016/07/26 09:28:46, yhirano wrote:
> I'm not sure what this #if directive is doing. Can you explain?

DCHECK requires the statement be well-formed, while ASSERT doesn't require it.
Since, |m_thread| is defined only when DCHECK_IS_ON(), we can not refer to it
even in DCHECK().

https://codereview.chromium.org/2181213003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.h
(right):

https://codereview.chromium.org/2181213003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.h:40: #if
ENABLE(ASSERT)
On 2016/07/26 09:28:46, yhirano wrote:
> This should be fixed.

Done.

[tzik, 2016-07-26 09:36:12]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 09:36:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-07-26 09:40:08]

lgtm

[haraken, 2016-07-26 09:40:47]

LGTM

[commit-bot: I haz the power, 2016-07-26 10:51:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 10:52:00]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tzik, 2016-07-26 11:46:18]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 11:46:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2016-07-26 11:47:06]

The CQ bit was unchecked by tzik@chromium.org

[tzik, 2016-07-26 11:47:33]

The CQ bit was checked by tzik@chromium.org

[tzik, 2016-07-26 11:47:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2181213003/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2016-07-26 11:47:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2016-07-26 11:48:19]

Description was changed from

==========
Use DCHECK instead of ASSERT in DataConsumerHandle-related stuff

BUG=
==========

to

==========
Use DCHECK instead of ASSERT in DataConsumerHandle-related stuff
==========

[commit-bot: I haz the power, 2016-07-26 15:14:38]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-26 15:16:28]

Description was changed from

==========
Use DCHECK instead of ASSERT in DataConsumerHandle-related stuff
==========

to

==========
Use DCHECK instead of ASSERT in DataConsumerHandle-related stuff

Committed: https://crrev.com/b2ed8e370f659625f435d414cfc0cce5aadadedf
Cr-Commit-Position: refs/heads/master@{#407799}
==========

[commit-bot: I haz the power, 2016-07-26 15:16:29]

Patchset 5 (id:??) landed as
https://crrev.com/b2ed8e370f659625f435d414cfc0cce5aadadedf
Cr-Commit-Position: refs/heads/master@{#407799}