Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Unified Diff: third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.h

Issue 2181213003: Use DCHECK instead of ASSERT in DataConsumerHandle-related stuff (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@data_consumer_handle_unique_ptr
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.h
diff --git a/third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.h b/third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.h
index e2a95d2d87bb10a4d4e41d5b106daea6b406b34a..90f33cf3dc6ecfce5aa33cdd58600a34f0279165 100644
--- a/third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.h
+++ b/third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.h
@@ -37,7 +37,7 @@ public:
private:
RefPtr<Context> m_context;
-#if ENABLE(ASSERT)
+#if DCHECK_IS_ON()
WebThread* const m_thread;
#endif
};
@@ -48,7 +48,7 @@ public:
template<typename T>
static std::unique_ptr<WebDataConsumerHandle> create(std::unique_ptr<WebDataConsumerHandle> handle, T* updater)
{
- ASSERT(handle);
+ DCHECK(handle);
Updater* u = nullptr;
std::unique_ptr<CompositeDataConsumerHandle> p = wrapUnique(new CompositeDataConsumerHandle(std::move(handle), &u));
*updater = u;
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698