Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Unified Diff: third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.cpp

Issue 2181213003: Use DCHECK instead of ASSERT in DataConsumerHandle-related stuff (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@data_consumer_handle_unique_ptr
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.cpp b/third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.cpp
index 7afd0c9a68011ef0fe449e66861e21f654084f26..2d0d5caeadd66da32fa875a3527d5b16f480a445 100644
--- a/third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.cpp
+++ b/third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.cpp
@@ -37,16 +37,16 @@ public:
static PassRefPtr<Context> create(std::unique_ptr<WebDataConsumerHandle> handle) { return adoptRef(new Context(std::move(handle))); }
~Context()
{
- ASSERT(!m_readerThread);
- ASSERT(!m_reader);
- ASSERT(!m_client);
+ DCHECK(!m_readerThread);
+ DCHECK(!m_reader);
+ DCHECK(!m_client);
}
std::unique_ptr<ReaderImpl> obtainReader(Client* client)
{
MutexLocker locker(m_mutex);
- ASSERT(!m_readerThread);
- ASSERT(!m_reader);
- ASSERT(!m_client);
+ DCHECK(!m_readerThread);
+ DCHECK(!m_reader);
+ DCHECK(!m_client);
++m_token;
m_client = client;
m_readerThread = Platform::current()->currentThread();
@@ -56,11 +56,11 @@ public:
void detachReader()
{
MutexLocker locker(m_mutex);
- ASSERT(m_readerThread);
- ASSERT(m_readerThread->isCurrentThread());
- ASSERT(m_reader);
- ASSERT(!m_isInTwoPhaseRead);
- ASSERT(!m_isUpdateWaitingForEndRead);
+ DCHECK(m_readerThread);
+ DCHECK(m_readerThread->isCurrentThread());
+ DCHECK(m_reader);
+ DCHECK(!m_isInTwoPhaseRead);
+ DCHECK(!m_isUpdateWaitingForEndRead);
++m_token;
m_reader = nullptr;
m_readerThread = nullptr;
@@ -80,21 +80,21 @@ public:
Result read(void* data, size_t size, Flags flags, size_t* readSize)
{
- ASSERT(m_readerThread && m_readerThread->isCurrentThread());
+ DCHECK(m_readerThread && m_readerThread->isCurrentThread());
return m_reader->read(data, size, flags, readSize);
}
Result beginRead(const void** buffer, Flags flags, size_t* available)
{
- ASSERT(m_readerThread && m_readerThread->isCurrentThread());
- ASSERT(!m_isInTwoPhaseRead);
+ DCHECK(m_readerThread && m_readerThread->isCurrentThread());
+ DCHECK(!m_isInTwoPhaseRead);
Result r = m_reader->beginRead(buffer, flags, available);
m_isInTwoPhaseRead = (r == Ok);
return r;
}
Result endRead(size_t readSize)
{
- ASSERT(m_readerThread && m_readerThread->isCurrentThread());
- ASSERT(m_isInTwoPhaseRead);
+ DCHECK(m_readerThread && m_readerThread->isCurrentThread());
+ DCHECK(m_isInTwoPhaseRead);
Result r = m_reader->endRead(readSize);
m_isInTwoPhaseRead = false;
if (m_isUpdateWaitingForEndRead) {
@@ -128,8 +128,8 @@ private:
// This request is not fresh. Ignore it.
return;
}
- ASSERT(m_readerThread);
- ASSERT(m_reader);
+ DCHECK(m_readerThread);
+ DCHECK(m_reader);
if (m_readerThread->isCurrentThread()) {
if (m_isInTwoPhaseRead) {
// We are waiting for the two-phase read completion.
@@ -186,7 +186,7 @@ Result CompositeDataConsumerHandle::ReaderImpl::endRead(size_t readSize)
CompositeDataConsumerHandle::Updater::Updater(PassRefPtr<Context> context)
: m_context(context)
-#if ENABLE(ASSERT)
+#if DCHECK_IS_ON()
, m_thread(Platform::current()->currentThread())
#endif
{
@@ -196,8 +196,10 @@ CompositeDataConsumerHandle::Updater::~Updater() {}
void CompositeDataConsumerHandle::Updater::update(std::unique_ptr<WebDataConsumerHandle> handle)
{
- ASSERT(handle);
- ASSERT(m_thread->isCurrentThread());
+ DCHECK(handle);
+#if DCHECK_IS_ON()
+ DCHECK(m_thread->isCurrentThread());
+#endif
m_context->update(std::move(handle));
}

Powered by Google App Engine
This is Rietveld 408576698