Issue 2180993002: Gamepad: Fix GYP build on Linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2180993002: Gamepad: Fix GYP build on Linux (Closed)

Created:
4 years, 4 months ago by bajones

Modified:
4 years, 4 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

Gamepad: Fix GYP build on Linux GN config on Linux has a dependency on //device/udev_linux when use_udev==1, but GYP config does not have the equivalent. This is failing GYP build on Linux. This gyp file was changed in https://codereview.chromium.org/2081583002 BUG=612330 Review-Url: https://codereview.chromium.org/2132453002 Cr-Commit-Position: refs/heads/master@{#404173} (cherry picked from commit 67b3938316821d5ccd3d41b2c002f99b1dd125c1) Committed: https://chromium.googlesource.com/chromium/src/+/b0a840ef9f1a53c8b655313fda9c06d4f91f2737

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	device/gamepad/gamepad.gyp	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

bajones

4 years, 4 months ago (2016-07-25 18:52:06 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b0a840ef9f1a53c8b655313fda9c06d4f91f2737.