Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2132453002:
Gamepad: Fix GYP build on Linux (Closed)
DescriptionGamepad: Fix GYP build on Linux
GN config on Linux has a dependency on //device/udev_linux when use_udev==1, but
GYP config does not have the equivalent. This is failing GYP build on Linux.
This gyp file was changed in
https://codereview.chromium.org/2081583002
BUG=612330
Committed: https://crrev.com/67b3938316821d5ccd3d41b2c002f99b1dd125c1
Cr-Commit-Position: refs/heads/master@{#404173}
Patch Set 1 #
Messages
Total messages: 14 (8 generated)
Description was changed from ========== Gamepad: Fix GYP build on Linux BUG=612330 ========== to ========== Gamepad: Fix GYP build on Linux GN config on Linux has a dependency on //device/udev_linux when use_udev==1, but GYP config does not have the equivalent. This is failing GYP build on Linux. BUG=612330 ==========
Description was changed from ========== Gamepad: Fix GYP build on Linux GN config on Linux has a dependency on //device/udev_linux when use_udev==1, but GYP config does not have the equivalent. This is failing GYP build on Linux. BUG=612330 ========== to ========== Gamepad: Fix GYP build on Linux GN config on Linux has a dependency on //device/udev_linux when use_udev==1, but GYP config does not have the equivalent. This is failing GYP build on Linux. This gyp file was changed in https://codereview.chromium.org/2081583002 BUG=612330 ==========
Patchset #1 (id:1) has been deleted
Description was changed from ========== Gamepad: Fix GYP build on Linux GN config on Linux has a dependency on //device/udev_linux when use_udev==1, but GYP config does not have the equivalent. This is failing GYP build on Linux. This gyp file was changed in https://codereview.chromium.org/2081583002 BUG=612330 ========== to ========== Gamepad: Fix GYP build on Linux GN config on Linux has a dependency on //device/udev_linux when use_udev==1, but GYP config does not have the equivalent. This is failing GYP build on Linux. This gyp file was changed in https://codereview.chromium.org/2081583002 BUG=612330 ==========
nhiroki@chromium.org changed reviewers: + bajones@chromium.org
bajones@, could you review this?
When I compile the current ToT on Linux without this change, I see following errors: ../../device/gamepad/gamepad_platform_data_fetcher_linux.cc:82: error: undefined reference to 'device::UdevLinux::UdevLinux(std::__debug::vector<device::UdevLinux::UdevMonitorFilter, std::allocator<device::UdevLinux::UdevMonitorFilter> > const&, base::Callback<void (udev_ device*), (base::internal::CopyMode)1> const&)' ../../device/gamepad/gamepad_platform_data_fetcher_linux.cc:125: error: undefined reference to 'device::udev_device_get_parent_with_subsystem_devtype(udev_device*, char const*, char const*)' ../../device/gamepad/gamepad_platform_data_fetcher_linux.cc:141: error: undefined reference to 'device::udev_device_get_sysattr_value(udev_device*, char const*)' ../../device/gamepad/gamepad_platform_data_fetcher_linux.cc:142: error: undefined reference to 'device::udev_device_get_sysattr_value(udev_device*, char const*)' ../../device/gamepad/gamepad_platform_data_fetcher_linux.cc:147: error: undefined reference to 'device::udev_device_get_sysattr_value(udev_device*, char const*)' ../../device/gamepad/gamepad_platform_data_fetcher_linux.cc:154: error: undefined reference to 'device::udev_device_get_parent_with_subsystem_devtype(udev_device*, char const*, char const*)' ../../device/gamepad/gamepad_platform_data_fetcher_linux.cc:158: error: undefined reference to 'device::udev_device_get_sysattr_value(udev_device*, char const*)' ../../device/gamepad/gamepad_platform_data_fetcher_linux.cc:205: error: undefined reference to 'device::UdevLinux::udev_handle()' ../../device/gamepad/gamepad_platform_data_fetcher_linux.cc:205: error: undefined reference to 'device::udev_enumerate_new(udev*)' ../../device/gamepad/gamepad_platform_data_fetcher_linux.cc:209: error: undefined reference to 'device::udev_enumerate_add_match_subsystem(udev_enumerate*, char const*)' ../../device/gamepad/gamepad_platform_data_fetcher_linux.cc:212: error: undefined reference to 'device::udev_enumerate_scan_devices(udev_enumerate*)' ../../device/gamepad/gamepad_platform_data_fetcher_linux.cc:216: error: undefined reference to 'device::udev_enumerate_get_list_entry(udev_enumerate*)' ../../device/gamepad/gamepad_platform_data_fetcher_linux.cc:221: error: undefined reference to 'device::udev_list_entry_get_name(udev_list_entry*)' ../../device/gamepad/gamepad_platform_data_fetcher_linux.cc:223: error: undefined reference to 'device::UdevLinux::udev_handle()' ../../device/gamepad/gamepad_platform_data_fetcher_linux.cc:223: error: undefined reference to 'device::udev_device_new_from_syspath(udev*, char const*)' ../../device/gamepad/gamepad_platform_data_fetcher_linux.cc:218: error: undefined reference to 'device::udev_list_entry_get_next(udev_list_entry*)' ../../device/gamepad/gamepad_platform_data_fetcher_linux.cc:38: error: undefined reference to 'device::udev_device_get_property_value(udev_device*, char const*)' ../../device/gamepad/gamepad_platform_data_fetcher_linux.cc:41: error: undefined reference to 'device::udev_device_get_devnode(udev_device*)' ../../device/udev_linux/scoped_udev.h:25: error: undefined reference to 'device::udev_enumerate_unref(udev_enumerate*)' ../../device/udev_linux/scoped_udev.h:30: error: undefined reference to 'device::udev_device_unref(udev_device*)' clang: error: linker command failed with exit code 1 (use -v to see invocation)
LGTM
The CQ bit was checked by nhiroki@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Gamepad: Fix GYP build on Linux GN config on Linux has a dependency on //device/udev_linux when use_udev==1, but GYP config does not have the equivalent. This is failing GYP build on Linux. This gyp file was changed in https://codereview.chromium.org/2081583002 BUG=612330 ========== to ========== Gamepad: Fix GYP build on Linux GN config on Linux has a dependency on //device/udev_linux when use_udev==1, but GYP config does not have the equivalent. This is failing GYP build on Linux. This gyp file was changed in https://codereview.chromium.org/2081583002 BUG=612330 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Gamepad: Fix GYP build on Linux GN config on Linux has a dependency on //device/udev_linux when use_udev==1, but GYP config does not have the equivalent. This is failing GYP build on Linux. This gyp file was changed in https://codereview.chromium.org/2081583002 BUG=612330 ========== to ========== Gamepad: Fix GYP build on Linux GN config on Linux has a dependency on //device/udev_linux when use_udev==1, but GYP config does not have the equivalent. This is failing GYP build on Linux. This gyp file was changed in https://codereview.chromium.org/2081583002 BUG=612330 Committed: https://crrev.com/67b3938316821d5ccd3d41b2c002f99b1dd125c1 Cr-Commit-Position: refs/heads/master@{#404173} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/67b3938316821d5ccd3d41b2c002f99b1dd125c1 Cr-Commit-Position: refs/heads/master@{#404173} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
