Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2180803002: Converted Observatory vm-connect element (Closed)

Created:
4 years, 5 months ago by cbernaschina
Modified:
4 years, 4 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : Removed temporary commented code #

Total comments: 4

Patch Set 3 : Reverted merge code regression #

Patch Set 4 : Added tests #

Total comments: 2

Patch Set 5 : Renamed DumpRepository to CrashDumpRepository #

Unified diffs Side-by-side diffs Delta from patch set Stats (+539 lines, -340 lines) Patch
M runtime/observatory/lib/app.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/elements.dart View 1 2 3 4 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/observatory/lib/elements.html View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/mocks.dart View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/observatory/lib/models.dart View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/observatory/lib/repositories.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/app/application.dart View 1 2 5 chunks +11 lines, -9 lines 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 1 2 3 4 2 chunks +7 lines, -2 lines 0 comments Download
D runtime/observatory/lib/src/app/target_manager.dart View 1 chunk +0 lines, -130 lines 0 comments Download
M runtime/observatory/lib/src/elements/css/shared.css View 2 chunks +7 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/vm_connect.dart View 1 2 3 4 1 chunk +153 lines, -40 lines 0 comments Download
D runtime/observatory/lib/src/elements/vm_connect.html View 1 2 3 4 1 chunk +0 lines, -60 lines 0 comments Download
M runtime/observatory/lib/src/elements/vm_connect_target.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D runtime/observatory/lib/src/elements/vm_connect_target_wrapper.dart View 1 2 3 4 1 chunk +0 lines, -80 lines 0 comments Download
A runtime/observatory/lib/src/mocks/repositories/crash_dump.dart View 1 2 3 4 1 chunk +23 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/mocks/repositories/target.dart View 1 2 3 1 chunk +72 lines, -0 lines 0 comments Download
A + runtime/observatory/lib/src/models/repositories/crash_dump.dart View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
A runtime/observatory/lib/src/models/repositories/target.dart View 1 chunk +19 lines, -0 lines 0 comments Download
A + runtime/observatory/lib/src/repositories/settings.dart View 3 chunks +6 lines, -6 lines 0 comments Download
A runtime/observatory/lib/src/repositories/target.dart View 1 chunk +102 lines, -0 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 2 3 4 4 chunks +5 lines, -3 lines 0 comments Download
A runtime/observatory/tests/observatory_ui/vm_connect/element_test.dart View 1 2 3 4 1 chunk +119 lines, -0 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/vm_connect/element_test.html View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 14 (2 generated)
cbernaschina
4 years, 5 months ago (2016-07-25 00:06:54 UTC) #2
Cutch
https://codereview.chromium.org/2180803002/diff/1/runtime/observatory/lib/src/app/application.dart File runtime/observatory/lib/src/app/application.dart (right): https://codereview.chromium.org/2180803002/diff/1/runtime/observatory/lib/src/app/application.dart#newcode21 runtime/observatory/lib/src/app/application.dart:21: _setVM(VM vm) { why was this made private? https://codereview.chromium.org/2180803002/diff/1/runtime/observatory/lib/src/app/application.dart#newcode53 ...
4 years, 5 months ago (2016-07-25 13:57:15 UTC) #3
cbernaschina
https://codereview.chromium.org/2180803002/diff/1/runtime/observatory/lib/src/app/application.dart File runtime/observatory/lib/src/app/application.dart (right): https://codereview.chromium.org/2180803002/diff/1/runtime/observatory/lib/src/app/application.dart#newcode21 runtime/observatory/lib/src/app/application.dart:21: _setVM(VM vm) { On 2016/07/25 13:57:15, Cutch wrote: > ...
4 years, 5 months ago (2016-07-25 17:27:28 UTC) #4
Cutch
https://codereview.chromium.org/2180803002/diff/20001/runtime/observatory/lib/src/app/application.dart File runtime/observatory/lib/src/app/application.dart (right): https://codereview.chromium.org/2180803002/diff/20001/runtime/observatory/lib/src/app/application.dart#newcode68 runtime/observatory/lib/src/app/application.dart:68: void removePauseEvents(Isolate isolate) { This could be made much ...
4 years, 5 months ago (2016-07-25 20:26:23 UTC) #5
cbernaschina
https://codereview.chromium.org/2180803002/diff/20001/runtime/observatory/lib/src/app/application.dart File runtime/observatory/lib/src/app/application.dart (right): https://codereview.chromium.org/2180803002/diff/20001/runtime/observatory/lib/src/app/application.dart#newcode68 runtime/observatory/lib/src/app/application.dart:68: void removePauseEvents(Isolate isolate) { On 2016/07/25 20:26:22, Cutch wrote: ...
4 years, 5 months ago (2016-07-25 20:36:25 UTC) #6
cbernaschina
4 years, 4 months ago (2016-07-26 01:10:30 UTC) #7
Cutch
https://codereview.chromium.org/2180803002/diff/20001/runtime/observatory/lib/src/app/application.dart File runtime/observatory/lib/src/app/application.dart (right): https://codereview.chromium.org/2180803002/diff/20001/runtime/observatory/lib/src/app/application.dart#newcode220 runtime/observatory/lib/src/app/application.dart:220: var remove = notifications.list().where((notification) { this still isn't using ...
4 years, 4 months ago (2016-07-26 14:47:53 UTC) #8
cbernaschina
https://chromiumcodereview.appspot.com/2180803002/diff/20001/runtime/observatory/lib/src/app/application.dart File runtime/observatory/lib/src/app/application.dart (right): https://chromiumcodereview.appspot.com/2180803002/diff/20001/runtime/observatory/lib/src/app/application.dart#newcode220 runtime/observatory/lib/src/app/application.dart:220: var remove = notifications.list().where((notification) { On 2016/07/26 14:47:53, Cutch ...
4 years, 4 months ago (2016-07-26 20:02:35 UTC) #9
Cutch
lgtm
4 years, 4 months ago (2016-07-26 20:20:28 UTC) #10
rmacnak
lgtm https://chromiumcodereview.appspot.com/2180803002/diff/60001/runtime/observatory/lib/src/models/repositories/dump.dart File runtime/observatory/lib/src/models/repositories/dump.dart (right): https://chromiumcodereview.appspot.com/2180803002/diff/60001/runtime/observatory/lib/src/models/repositories/dump.dart#newcode7 runtime/observatory/lib/src/models/repositories/dump.dart:7: abstract class DumpRepository { Consider "CrashDumpRepository"
4 years, 4 months ago (2016-07-27 19:33:44 UTC) #11
cbernaschina
https://chromiumcodereview.appspot.com/2180803002/diff/60001/runtime/observatory/lib/src/models/repositories/dump.dart File runtime/observatory/lib/src/models/repositories/dump.dart (right): https://chromiumcodereview.appspot.com/2180803002/diff/60001/runtime/observatory/lib/src/models/repositories/dump.dart#newcode7 runtime/observatory/lib/src/models/repositories/dump.dart:7: abstract class DumpRepository { On 2016/07/27 19:33:44, rmacnak wrote: ...
4 years, 4 months ago (2016-07-27 20:43:33 UTC) #12
cbernaschina
4 years, 4 months ago (2016-07-27 20:43:49 UTC) #14
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
cb468c2c47d5cbf1d8d5f6cea2d56c102513f86f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698