Converted Observatory vm-connect element

runtime/observatory/lib/src/app/page.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of app;
 
 class IsolateNotFound implements Exception {
   String isolateId;
   IsolateNotFound(this.isolateId);
   String toString() => "IsolateNotFound: $isolateId";
 }
 
 /// A [Page] controls the user interface of Observatory. At any given time
 /// one page will be the current page. Pages are registered at startup.
 /// When the user navigates within the application, each page is asked if it
 /// can handle the current location, the first page to say yes, wins.
 abstract class Page extends Observable {
   final ObservatoryApplication app;
   final ObservableMap<String, String> internalArguments =
       new ObservableMap<String, String>();
-  @observable ObservatoryElement element;
+  @observable HtmlElement element;
 
   Page(this.app);
 
   /// Called when the page is installed, this callback must initialize
   /// [element].
   void onInstall();
 
   /// Called when the page is uninstalled, this callback must clear
   /// [element].
   void onUninstall() {
@@ skipping 331 matching lines @@
 
   // TODO(turnidge): How to test this page?
   bool canVisit(Uri uri) => uri.path == 'error';
 }
 
 class VMConnectPage extends Page {
   VMConnectPage(app) : super(app);
 
   void onInstall() {
     if (element == null) {
-      element = new Element.tag('vm-connect');
+      element = new VMConnectElement(
+            ObservatoryApplication.app.targets,
+            new DumpRepositoryMock(ObservatoryApplication.app.loadCrashDump),

[Cutch, 2016/07/25 13:57:15]

why are we using a mock here?

[cbernaschina, 2016/07/25 17:27:28]

It is to adapt the method name from loadCrashDump to load.
We can potentially remove it calling the method in the repository in the same
way.

+            ObservatoryApplication.app.notifications,
+            queue: ObservatoryApplication.app.queue);
     }
     assert(element != null);
   }
 
   void _visit(Uri uri) {
     assert(element != null);
     assert(canVisit(uri));
   }
 
   bool canVisit(Uri uri) => uri.path == 'vm-connect';
@@ skipping 87 matching lines @@
     assert(element != null);
   }
 
   void _visit(Uri uri) {
     assert(element != null);
     assert(canVisit(uri));
   }
 
   bool canVisit(Uri uri) => uri.path == 'timeline';
 }