runtime/observatory/observatory_sources.gypi - Issue 2180803002: Converted Observatory vm-connect element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/observatory_sources.gypi

Issue 2180803002: Converted Observatory vm-connect element (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Renamed DumpRepository to CrashDumpRepository Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/observatory/lib/src/repositories/target.dart ('k') | runtime/observatory/tests/observatory_ui/vm_connect/element_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/observatory_sources.gypi

diff --git a/runtime/observatory/observatory_sources.gypi b/runtime/observatory/observatory_sources.gypi

index 30659e0bde0b4c2bbc1877910b5a8354ac2c4f2d..edf79b90ddf9b17e43add8c7d04dd86af70c444b 100644

--- a/runtime/observatory/observatory_sources.gypi

+++ b/runtime/observatory/observatory_sources.gypi

@@ -25,7 +25,6 @@

'lib/src/app/notification.dart',

'lib/src/app/page.dart',

'lib/src/app/settings.dart',

- 'lib/src/app/target_manager.dart',

'lib/src/app/view_model.dart',

'lib/src/cli/command.dart',

'lib/src/cpu_profile/cpu_profile.dart',

@@ -170,9 +169,7 @@

'lib/src/elements/timeline_page.html',

'lib/src/elements/view_footer.dart',

'lib/src/elements/vm_connect_target.dart',

- 'lib/src/elements/vm_connect_target_wrapper.dart',

'lib/src/elements/vm_connect.dart',

- 'lib/src/elements/vm_connect.html',

'lib/src/elements/vm_view.dart',

'lib/src/elements/vm_view.html',

'lib/src/mocks/exceptions/connection_exception.dart',

@@ -186,6 +183,7 @@

'lib/src/mocks/objects/source_location.dart',

'lib/src/mocks/objects/target.dart',

'lib/src/mocks/objects/vm.dart',

+ 'lib/src/mocks/repositories/crash_dump.dart',

'lib/src/mocks/repositories/notification.dart',

'lib/src/models/exceptions.dart',

'lib/src/models/objects/breakpoint.dart',

@@ -204,8 +202,12 @@

'lib/src/models/objects/target.dart',

'lib/src/models/objects/timeline_event.dart',

'lib/src/models/objects/vm.dart',

+ 'lib/src/models/repositories/crash_dump.dart',

'lib/src/models/repositories/notification.dart',

+ 'lib/src/models/repositories/target.dart',

'lib/src/repositories/notification.dart',

+ 'lib/src/repositories/settings.dart',

+ 'lib/src/repositories/target.dart',

'lib/src/service/object.dart',

'lib/tracer.dart',

'lib/utils.dart',