Use actual type instead CFX_Deletable

Use actual type instead CFX_Deletable

Change two places that used CFX_Deletable to use actual types. This makes
the type more obvious, and avoids unnecessary casts.

Committed: https://pdfium.googlesource.com/pdfium/+/9f515bcccb40e8ae251bbe8afc1ef6c4db1f05a8

[Wei Li, 2016-07-22 18:19:16]

Description was changed from

==========
Use actual type instead CFX_Deletable

Change two places that use CFX_Deletable to actual types. This makes
the type more obvious, and avoids unnecessary casts.
==========

to

==========
Use actual type instead CFX_Deletable

Change two places that used CFX_Deletable to use actual types. This makes
the type more obvious, and avoids unnecessary casts.
==========

[Wei Li, 2016-07-22 18:21:42]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 18:21:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 18:36:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 18:36:02]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-07-22 18:43:49]

weili@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org

[Wei Li, 2016-07-22 18:43:50]

pls review, thanks

[Lei Zhang, 2016-07-22 22:49:17]

Oh, hmm, there's already a CPDF_RenderContext. I find the location of the new
file + name odd, but I can't think of anything better.

https://codereview.chromium.org/2180443002/diff/20001/core/fpdfapi/include/cp...
File core/fpdfapi/include/cpdf_modulemgr.h (right):

https://codereview.chromium.org/2180443002/diff/20001/core/fpdfapi/include/cp...
core/fpdfapi/include/cpdf_modulemgr.h:26: explicit
CFSDK_UnsupportInfo_Adapter(struct _UNSUPPORT_INFO* unsp_info)
Just use a void* ? We are not suppose to know about a struct in public/

https://codereview.chromium.org/2180443002/diff/20001/core/fpdfapi/rendercont...
File core/fpdfapi/rendercontext.cpp (right):

https://codereview.chromium.org/2180443002/diff/20001/core/fpdfapi/rendercont...
core/fpdfapi/rendercontext.cpp:9: #include
"core/fpdfapi/fpdf_render/include/cpdf_progressiverenderer.h"
Do we need all these includes?

https://codereview.chromium.org/2180443002/diff/20001/core/fpdfapi/rendercont...
core/fpdfapi/rendercontext.cpp:19: delete m_pOptions->m_pOCContext;
A bit worried here because CRenderContext doesn't initialize |m_pOptions|. If we
create a CRenderContext and delete it, this crashes.

https://codereview.chromium.org/2180443002/diff/20001/fpdfsdk/fsdk_pauseadapt...
File fpdfsdk/fsdk_pauseadapter.cpp (right):

https://codereview.chromium.org/2180443002/diff/20001/fpdfsdk/fsdk_pauseadapt...
fpdfsdk/fsdk_pauseadapter.cpp:10: m_IPause = IPause;
Use the initializer list.

https://codereview.chromium.org/2180443002/diff/20001/fpdfsdk/include/fsdk_pa...
File fpdfsdk/include/fsdk_pauseadapter.h (right):

https://codereview.chromium.org/2180443002/diff/20001/fpdfsdk/include/fsdk_pa...
fpdfsdk/include/fsdk_pauseadapter.h:22: IFSDK_PAUSE* m_IPause;
IFSDK_PAUSE* const m_IPause;

[Wei Li, 2016-07-23 01:03:05]

Patchset #3 (id:40001) has been deleted

[Wei Li, 2016-07-23 01:12:49]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-23 01:12:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-23 01:19:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-23 01:19:06]

Dry run: Try jobs failed on following builders:
  linux_xfa_rel_gyp on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa_rel_g...)

[Wei Li, 2016-07-23 02:13:30]

Patchset #3 (id:60001) has been deleted

[Wei Li, 2016-07-23 02:16:22]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-23 02:16:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-23 02:21:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-23 02:21:58]

Dry run: Try jobs failed on following builders:
  mac_no_v8 on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/mac_no_v8/build...)

[Wei Li, 2016-07-23 02:29:54]

Patchset #3 (id:80001) has been deleted

[Wei Li, 2016-07-23 02:30:04]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-23 02:30:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-23 02:45:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-23 02:45:17]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-07-23 02:59:30]

Patchset #3 (id:100001) has been deleted

[Wei Li, 2016-07-23 03:01:13]

Changed CRenderContext to CPDF_PageRenderContext as it is only used in
RenderPage* functions and is owned by CPDF_page. Hope it looks better.

https://codereview.chromium.org/2180443002/diff/20001/core/fpdfapi/include/cp...
File core/fpdfapi/include/cpdf_modulemgr.h (right):

https://codereview.chromium.org/2180443002/diff/20001/core/fpdfapi/include/cp...
core/fpdfapi/include/cpdf_modulemgr.h:26: explicit
CFSDK_UnsupportInfo_Adapter(struct _UNSUPPORT_INFO* unsp_info)
On 2016/07/22 22:49:16, Lei Zhang wrote:
> Just use a void* ? We are not suppose to know about a struct in public/

Done.

https://codereview.chromium.org/2180443002/diff/20001/core/fpdfapi/rendercont...
File core/fpdfapi/rendercontext.cpp (right):

https://codereview.chromium.org/2180443002/diff/20001/core/fpdfapi/rendercont...
core/fpdfapi/rendercontext.cpp:9: #include
"core/fpdfapi/fpdf_render/include/cpdf_progressiverenderer.h"
On 2016/07/22 22:49:16, Lei Zhang wrote:
> Do we need all these includes?

Yes, since I only use forward declaration in the header file.
The constructor/destructor needs the class definitions for all member variables
from these includes.

https://codereview.chromium.org/2180443002/diff/20001/core/fpdfapi/rendercont...
core/fpdfapi/rendercontext.cpp:19: delete m_pOptions->m_pOCContext;
On 2016/07/22 22:49:16, Lei Zhang wrote:
> A bit worried here because CRenderContext doesn't initialize |m_pOptions|. If
we
> create a CRenderContext and delete it, this crashes.

The use of |m_pOCContext| is a bit messy.
Added a check.

https://codereview.chromium.org/2180443002/diff/20001/fpdfsdk/fsdk_pauseadapt...
File fpdfsdk/fsdk_pauseadapter.cpp (right):

https://codereview.chromium.org/2180443002/diff/20001/fpdfsdk/fsdk_pauseadapt...
fpdfsdk/fsdk_pauseadapter.cpp:10: m_IPause = IPause;
On 2016/07/22 22:49:16, Lei Zhang wrote:
> Use the initializer list.

Done.

https://codereview.chromium.org/2180443002/diff/20001/fpdfsdk/include/fsdk_pa...
File fpdfsdk/include/fsdk_pauseadapter.h (right):

https://codereview.chromium.org/2180443002/diff/20001/fpdfsdk/include/fsdk_pa...
fpdfsdk/include/fsdk_pauseadapter.h:22: IFSDK_PAUSE* m_IPause;
On 2016/07/22 22:49:17, Lei Zhang wrote:
> IFSDK_PAUSE* const m_IPause;

Done.

[Wei Li, 2016-07-23 03:01:29]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-23 03:01:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-23 03:13:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-23 03:13:24]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-07-23 04:33:58]

lgtm

https://codereview.chromium.org/2180443002/diff/120001/core/fpdfapi/cpdf_page...
File core/fpdfapi/cpdf_pagerendercontext.cpp (right):

https://codereview.chromium.org/2180443002/diff/120001/core/fpdfapi/cpdf_page...
core/fpdfapi/cpdf_pagerendercontext.cpp:19: if (m_pOptions &&
m_pOptions->m_pOCContext)
You don't have to check m_pOptions->m_pOCContext, delete already does that
internally.

[Wei Li, 2016-07-24 14:52:02]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-24 14:52:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Wei Li, 2016-07-24 15:03:42]

thanks

https://codereview.chromium.org/2180443002/diff/120001/core/fpdfapi/cpdf_page...
File core/fpdfapi/cpdf_pagerendercontext.cpp (right):

https://codereview.chromium.org/2180443002/diff/120001/core/fpdfapi/cpdf_page...
core/fpdfapi/cpdf_pagerendercontext.cpp:19: if (m_pOptions &&
m_pOptions->m_pOCContext)
On 2016/07/23 04:33:58, Lei Zhang wrote:
> You don't have to check m_pOptions->m_pOCContext, delete already does that
> internally.

Done.

[commit-bot: I haz the power, 2016-07-24 15:03:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-24 15:03:59]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-07-24 15:08:02]

The CQ bit was checked by weili@chromium.org

[Wei Li, 2016-07-24 15:08:02]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2180443002/#ps140001
(title: "one more fix")

[commit-bot: I haz the power, 2016-07-24 15:08:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-24 15:08:30]

Description was changed from

==========
Use actual type instead CFX_Deletable

Change two places that used CFX_Deletable to use actual types. This makes
the type more obvious, and avoids unnecessary casts.
==========

to

==========
Use actual type instead CFX_Deletable

Change two places that used CFX_Deletable to use actual types. This makes
the type more obvious, and avoids unnecessary casts.

Committed:
https://pdfium.googlesource.com/pdfium/+/9f515bcccb40e8ae251bbe8afc1ef6c4db1f...
==========

[commit-bot: I haz the power, 2016-07-24 15:08:31]

Committed patchset #4 (id:140001) as
https://pdfium.googlesource.com/pdfium/+/9f515bcccb40e8ae251bbe8afc1ef6c4db1f...