Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2178613002: Remove CFX_Deletable (Closed)

Created:
4 years, 5 months ago by Wei Li
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@fix3
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove CFX_Deletable Change the last use of CFX_Deletable to its actual type and remove the use of CFX_Deletable. Committed: https://pdfium.googlesource.com/pdfium/+/0024a22b4a793630a1a8e8d85c4525c7b82a3ed7

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -45 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_document.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/fpdfapi/fpdf_parser/include/cpdf_document.h View 3 chunks +5 lines, -2 lines 0 comments Download
M core/fxcodec/codec/ccodec_jbig2module.h View 2 chunks +11 lines, -9 lines 0 comments Download
M core/fxcodec/codec/fx_codec_jbig.cpp View 3 chunks +10 lines, -22 lines 0 comments Download
A core/fxcodec/include/JBig2_DocumentContext.h View 1 chunk +34 lines, -0 lines 0 comments Download
M core/fxcodec/jbig2/JBig2_Context.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fxcodec/jbig2/JBig2_Context.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fxcrt/include/fx_memory.h View 1 chunk +0 lines, -5 lines 0 comments Download
M pdfium.gyp View 1 2 chunks +3 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (12 generated)
Wei Li
pls review, thanks
4 years, 5 months ago (2016-07-22 21:27:19 UTC) #6
Lei Zhang
lgtm https://codereview.chromium.org/2178613002/diff/1/core/fxcodec/include/JBig2_DocumentContext.h File core/fxcodec/include/JBig2_DocumentContext.h (right): https://codereview.chromium.org/2178613002/diff/1/core/fxcodec/include/JBig2_DocumentContext.h#newcode1 core/fxcodec/include/JBig2_DocumentContext.h:1: // Copyright 2016 PDFium Authors. All rights reserved. ...
4 years, 5 months ago (2016-07-22 23:01:00 UTC) #7
Wei Li
thanks https://codereview.chromium.org/2178613002/diff/1/core/fxcodec/include/JBig2_DocumentContext.h File core/fxcodec/include/JBig2_DocumentContext.h (right): https://codereview.chromium.org/2178613002/diff/1/core/fxcodec/include/JBig2_DocumentContext.h#newcode1 core/fxcodec/include/JBig2_DocumentContext.h:1: // Copyright 2016 PDFium Authors. All rights reserved. ...
4 years, 5 months ago (2016-07-24 15:26:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2178613002/20001
4 years, 5 months ago (2016-07-24 15:26:38 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-24 15:26:53 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/0024a22b4a793630a1a8e8d85c4525c7b82a...

Powered by Google App Engine
This is Rietveld 408576698