core/fpdfapi/cpdf_pagerendercontext.cpp - Issue 2180443002: Use actual type instead CFX_Deletable

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: core/fpdfapi/cpdf_pagerendercontext.cpp

Issue 2180443002: Use actual type instead CFX_Deletable (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: address comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 PDFium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

	6

	7 #include "core/fpdfapi/include/cpdf_pagerendercontext.h"

	8

	9 #include "core/fpdfapi/fpdf_render/include/cpdf_progressiverenderer.h"

	10 #include "core/fpdfapi/fpdf_render/include/cpdf_rendercontext.h"

	11 #include "core/fpdfapi/fpdf_render/include/cpdf_renderoptions.h"

	12 #include "core/fpdfdoc/cpdf_annotlist.h"

	13 #include "core/fpdfdoc/include/fpdf_doc.h"

	14 #include "core/fxge/include/fx_ge.h"

	15

	16 CPDF_PageRenderContext::CPDF_PageRenderContext() {}

	17

	18 CPDF_PageRenderContext::~CPDF_PageRenderContext() {

	19 if (m_pOptions && m_pOptions->m_pOCContext)
	Lei Zhang 2016/07/23 04:33:58 You don't have to check m_pOptions->m_pOCContext, You don't have to check m_pOptions->m_pOCContext, delete already does that internally. Wei Li 2016/07/24 15:03:42 Done. Show quoted text On 2016/07/23 04:33:58, Lei Zhang wrote: > You don't have to check m_pOptions->m_pOCContext, delete already does that > internally. Done.
	20 delete m_pOptions->m_pOCContext;

	21 }

OLD	NEW

« no previous file with comments | « BUILD.gn ('k') | core/fpdfapi/fpdf_page/cpdf_page.cpp » ('j') | no next file with comments »