chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java - Issue 2180293002: Remove the print option from the menu and make it a share destination.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

Issue 2180293002: Remove the print option from the menu and make it a share destination. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add proper icons Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/printing/PrintShareActivity.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/printing/PrintShareActivity.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

index d29d305fbe93421ee8de7a180eb26cd7ae8f3524..b7e2dff4935958ab43ec631d9791945782740995 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

@@ -630,9 +630,9 @@ public class CustomTabActivity extends ChromeActivity {

public boolean onMenuOrKeyboardAction(int id, boolean fromMenu) {

// Disable creating new tabs, bookmark, history, print, help, focus_url, etc.

if (id == R.id.focus_url_bar || id == R.id.all_bookmarks_menu_id

- || id == R.id.print_id || id == R.id.help_id

- || id == R.id.recent_tabs_menu_id || id == R.id.new_incognito_tab_menu_id

- || id == R.id.new_tab_menu_id || id == R.id.open_history_menu_id) {

+ || id == R.id.help_id || id == R.id.recent_tabs_menu_id

+ || id == R.id.new_incognito_tab_menu_id || id == R.id.new_tab_menu_id

+ || id == R.id.open_history_menu_id) {

return true;

} else if (id == R.id.open_in_browser_id) {

openCurrentUrlInBrowser(false, true);