chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java - Issue 2180293002: Remove the print option from the menu and make it a share destination.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

Issue 2180293002: Remove the print option from the menu and make it a share destination. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add proper icons Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/printing/PrintShareActivity.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

index 4da7e9a70964f74bfedee0f6cb28ce7ffd264730..0516138f48a22976ad81a202db1c984c230e5d5c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

@@ -23,7 +23,6 @@ import org.chromium.chrome.browser.share.ShareHelper;

import org.chromium.chrome.browser.tab.Tab;

import org.chromium.chrome.browser.util.FeatureUtilities;

import org.chromium.components.dom_distiller.core.DomDistillerUrlUtils;

-import org.chromium.printing.PrintingController;

import org.chromium.ui.base.DeviceFormFactor;

/**

@@ -154,14 +153,6 @@ public class AppMenuPropertiesDelegate {

? mActivity.getString(R.string.menu_request_desktop_site_on)

: mActivity.getString(R.string.menu_request_desktop_site_off));

- PrintingController printingController =

- mActivity.getChromeApplication().getPrintingController();

- disableEnableMenuItem(menu, R.id.print_id,

- printingController != null && !currentTab.isNativePage(),

- printingController != null && !printingController.isBusy()

- && PrefServiceBridge.getInstance().isPrintingEnabled(),

- PrefServiceBridge.getInstance().isPrintingManaged());

// Only display reader mode settings menu option if the current page is in reader mode.

menu.findItem(R.id.reader_mode_prefs_id)

.setVisible(DomDistillerUrlUtils.isDistilledPage(currentTab.getUrl()));