Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: gpu/ipc/common/android/dialog_surface_lookup.h

Issue 2178973004: DialogSurfaceManager implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed IDialogSurfaceActivityMapper from common.aidl Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/ipc/common/android/dialog_surface_lookup.h
diff --git a/gpu/ipc/common/android/dialog_surface_lookup.h b/gpu/ipc/common/android/dialog_surface_lookup.h
new file mode 100644
index 0000000000000000000000000000000000000000..b8d99d1d751ecd4c61fe47007e66889e87e10b06
--- /dev/null
+++ b/gpu/ipc/common/android/dialog_surface_lookup.h
@@ -0,0 +1,33 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef GPU_IPC_COMMON_ANDROID_DIALOG_SURFACE_LOOKUP_H_
+#define GPU_IPC_COMMON_ANDROID_DIALOG_SURFACE_LOOKUP_H_
+
+#include "base/android/scoped_java_ref.h"
+#include "base/macros.h"
+#include "gpu/gpu_export.h"
+
+namespace gpu {
+
+// This class provides an interface to look up the browser-based Dialog
+// Surface manager.
+class GPU_EXPORT DialogSurfaceLookup {
boliu 2017/01/04 23:14:39 DialogSurface*Manager*Lookup?
liberato (no reviews please) 2017/01/11 22:17:56 good point. Done.
+ public:
+ DialogSurfaceLookup() {}
+ virtual ~DialogSurfaceLookup() {}
+
+ static DialogSurfaceLookup* GetInstance();
+ static void InitInstance(DialogSurfaceLookup* lookup);
+
+ virtual base::android::ScopedJavaLocalRef<jobject>
boliu 2017/01/04 23:14:39 should document what this object actually is
liberato (no reviews please) 2017/01/11 22:17:56 Done.
+ GetDialogSurfaceManager() = 0;
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(DialogSurfaceLookup);
+};
+
+} // namespace gpu
+
+#endif // GPU_IPC_COMMON_ANDROID_DIALOG_SURFACE_LOOKUP_H_

Powered by Google App Engine
This is Rietveld 408576698