content/public/android/java/src/org/chromium/content/common/IChildProcessCallback.aidl - Issue 2178973004: DialogSurfaceManager implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/common/IChildProcessCallback.aidl

Issue 2178973004: DialogSurfaceManager implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed IDialogSurfaceActivityMapper from common.aidl Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/android/java/src/org/chromium/content/browser/DialogSurfaceWindowTokenProviderImpl.java ('K') | « content/public/android/java/src/org/chromium/content/browser/DialogSurfaceWindowTokenProviderImpl.java ('k') | gpu/ipc/common/BUILD.gn » ('j') | gpu/ipc/common/android/dialog_surface_lookup.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/common/IChildProcessCallback.aidl

diff --git a/content/public/android/java/src/org/chromium/content/common/IChildProcessCallback.aidl b/content/public/android/java/src/org/chromium/content/common/IChildProcessCallback.aidl

index 85bebb93b0087af262751e66fa561df059ec6e27..f32e22ae1f5f691af971be2b8eadf71488dc09ee 100644

--- a/content/public/android/java/src/org/chromium/content/common/IChildProcessCallback.aidl

+++ b/content/public/android/java/src/org/chromium/content/common/IChildProcessCallback.aidl

@@ -17,4 +17,7 @@ interface IChildProcessCallback {

in UnguessableToken requestToken, in Surface surface);

SurfaceWrapper getViewSurface(int surfaceId);

+ // Return the DialogSurfaceManager instance.

+ IBinder getDialogSurfaceManager();

boliu 2017/01/04 23:14:39 Manager only has a single method. Is it going to g

liberato (no reviews please) 2017/01/11 22:17:56 i expect that it will get more, based on my discus

}