Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Side by Side Diff: gpu/ipc/common/android/dialog_surface_lookup.h

Issue 2178973004: DialogSurfaceManager implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed IDialogSurfaceActivityMapper from common.aidl Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef GPU_IPC_COMMON_ANDROID_DIALOG_SURFACE_LOOKUP_H_
6 #define GPU_IPC_COMMON_ANDROID_DIALOG_SURFACE_LOOKUP_H_
7
8 #include "base/android/scoped_java_ref.h"
9 #include "base/macros.h"
10 #include "gpu/gpu_export.h"
11
12 namespace gpu {
13
14 // This class provides an interface to look up the browser-based Dialog
15 // Surface manager.
16 class GPU_EXPORT DialogSurfaceLookup {
boliu 2017/01/04 23:14:39 DialogSurface*Manager*Lookup?
liberato (no reviews please) 2017/01/11 22:17:56 good point. Done.
17 public:
18 DialogSurfaceLookup() {}
19 virtual ~DialogSurfaceLookup() {}
20
21 static DialogSurfaceLookup* GetInstance();
22 static void InitInstance(DialogSurfaceLookup* lookup);
23
24 virtual base::android::ScopedJavaLocalRef<jobject>
boliu 2017/01/04 23:14:39 should document what this object actually is
liberato (no reviews please) 2017/01/11 22:17:56 Done.
25 GetDialogSurfaceManager() = 0;
26
27 private:
28 DISALLOW_COPY_AND_ASSIGN(DialogSurfaceLookup);
29 };
30
31 } // namespace gpu
32
33 #endif // GPU_IPC_COMMON_ANDROID_DIALOG_SURFACE_LOOKUP_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698