Issue 217893004: Interface cleanup for WebGestureCurveTarget

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 217893004: Interface cleanup for WebGestureCurveTarget (Closed)

Created:
6 years, 8 months ago by jdduke (slow)

Modified:
6 years, 8 months ago

Reviewers:
aelias_OOO_until_Jul13, abarth-chromium

CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@input_fix_flingvel2

Visibility:
Public.

Interface cleanup for WebGestureCurveTarget This is the final patch in a three-part series towards early termination of flings when scrolling is impossible, cleaning up now unused portions of the WebGestureCurveTarget interface. Blink patch (#1) https://codereview.chromium.org/139493003/ Chromium patch (#2): https://codereview.chromium.org/136173004/ Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170887

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -14 lines)			Patch
M	Source/web/WebViewImpl.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/web/WebViewImpl.cpp	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
M	public/platform/WebGestureCurveTarget.h	View		1 chunk	+1 line, -8 lines	0 comments	Download

Total messages: 7 (0 generated)

aelias_OOO_until_Jul13

lgtm, adding abarth@ for public/platform OWNERS.

6 years, 8 months ago (2014-04-01 02:05:23 UTC) #2

jdduke (slow)

abarth@: Any issues with the changes to public/platform/WebGestureCurveTarget.h?

6 years, 8 months ago (2014-04-04 15:28:46 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/217893004/40001

6 years, 8 months ago (2014-04-04 17:06:21 UTC) #6

Message was sent while issue was closed.

Change committed as 170887