Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: public/platform/WebGestureCurveTarget.h

Issue 217893004: Interface cleanup for WebGestureCurveTarget (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@input_fix_flingvel2
Patch Set: Rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebViewImpl.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/WebGestureCurveTarget.h
diff --git a/public/platform/WebGestureCurveTarget.h b/public/platform/WebGestureCurveTarget.h
index a3c3338ebe494b5f5a2f8cc0a9abeaa0021d0034..1b8bfa830273130c495b230727320ee2b9b82ce8 100644
--- a/public/platform/WebGestureCurveTarget.h
+++ b/public/platform/WebGestureCurveTarget.h
@@ -32,14 +32,7 @@ namespace blink {
class WebGestureCurveTarget {
public:
- // TODO(jdduke): Make pure virtual when crrev.com/136173004 lands.
- virtual bool scrollBy(const WebFloatSize& delta, const WebFloatSize& velocity) { return false; }
-
- // TODO(jdduke): Remove when crrev.com/136173004 lands.
- virtual void scrollBy(const WebFloatSize& delta) { }
-
- // TODO(jdduke): Remove when crrev.com/136173004 lands.
- virtual void notifyCurrentFlingVelocity(const WebFloatSize& velocity) { }
+ virtual bool scrollBy(const WebFloatSize& delta, const WebFloatSize& velocity) = 0;
protected:
virtual ~WebGestureCurveTarget() { }
« no previous file with comments | « Source/web/WebViewImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698