Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 139493003: Early terminate flings when scrolling impossible (Closed)

Created:
6 years, 11 months ago by jdduke (slow)
Modified:
6 years, 8 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Early terminate flings when scrolling impossible Previously, flings would continue animating until they were either interrupted, or had reached the end of their respective curve. Instead, allow the fling to terminate early if they hit their limit, given the result of |WebGestureCurveTarget::scrollBy|. This saves power on sites where fling scrolls have little affordance. Also simplify WebGestureCurveTarget by consolidating scroll delta and velocity into a single method. Corresponding Chromium patch: https://codereview.chromium.org/136173004/ Final Blink cleanup patch: https://codereview.chromium.org/217893004 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170406

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Split up patch accordingly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M Source/web/WebViewImpl.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 1 2 3 chunks +9 lines, -3 lines 0 comments Download
M public/platform/WebGestureCurveTarget.h View 1 2 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
aelias_OOO_until_Jul13
lgtm. (Just think about how the Blink rolls are going to work when you change ...
6 years, 8 months ago (2014-03-28 23:57:50 UTC) #1
jdduke (slow)
jamesr@: Owner review for public/platform? Thanks.
6 years, 8 months ago (2014-03-29 01:11:00 UTC) #2
jdduke (slow)
Oops, should have paid attention to jamesr@ OOO label... abarth@: Owner review for public/platform? Thanks.
6 years, 8 months ago (2014-03-29 01:14:41 UTC) #3
abarth-chromium
lgtm
6 years, 8 months ago (2014-03-29 02:15:18 UTC) #4
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 8 months ago (2014-03-29 02:55:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/139493003/60001
6 years, 8 months ago (2014-03-29 02:55:09 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-29 03:05:22 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 8 months ago (2014-03-29 03:05:23 UTC) #8
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 8 months ago (2014-03-29 03:07:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/139493003/60001
6 years, 8 months ago (2014-03-29 03:08:00 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-03-29 04:04:44 UTC) #11
Message was sent while issue was closed.
Change committed as 170406

Powered by Google App Engine
This is Rietveld 408576698