core/fxcodec/jbig2/JBig2_Context.h - Issue 2178613002: Remove CFX_Deletable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxcodec/jbig2/JBig2_Context.h

Issue 2178613002: Remove CFX_Deletable (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@fix3

Patch Set: address comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxcodec/jbig2/JBig2_Context.h

diff --git a/core/fxcodec/jbig2/JBig2_Context.h b/core/fxcodec/jbig2/JBig2_Context.h

index 1577b22d37e6a524136bad22338db2c89fcddc4e..a0e1a8fcacfa3ea22ec229b8b6a29179121759a7 100644

--- a/core/fxcodec/jbig2/JBig2_Context.h

+++ b/core/fxcodec/jbig2/JBig2_Context.h

@@ -25,8 +25,8 @@ class IFX_Pause;

// Cache is keyed by the ObjNum of a stream and an index within the stream.

using CJBig2_CacheKey = std::pair<uint32_t, uint32_t>;

-// NB: CJBig2_SymbolDict* is owned.

-using CJBig2_CachePair = std::pair<CJBig2_CacheKey, CJBig2_SymbolDict*>;

+using CJBig2_CachePair =

+ std::pair<CJBig2_CacheKey, std::unique_ptr<CJBig2_SymbolDict>>;

#define JBIG2_SUCCESS 0

#define JBIG2_FAILED -1

« no previous file with comments | « core/fxcodec/include/JBig2_DocumentContext.h ('k') | core/fxcodec/jbig2/JBig2_Context.cpp » ('j') | no next file with comments »