Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2178243002: Make ExceptionState parameter of ContainerNode::querySelector() as an optional parameter (Closed)

Created:
4 years, 5 months ago by yosin_UTC9
Modified:
4 years, 5 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, groby+blinkspell_chromium.org, mlamouri+watch-blink_chromium.org, rwlbuis, sof, nessy, vcarbune.chromium, webcomponents-bugzilla_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ExceptionState parameter of ContainerNode::querySelector() as an optional parameter This patch makes |ExceptionState| parameter of |ContainerNode::querySelector()| as an optional parameter to reduce source code size for improving code readability and ease of writing tests, since there are lots of call of |querySelector()| with |ASSERT_NO_EXCEPTION| in Blink unit tests. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/d7447926b684013f332153de1bd502dd2bcecb25 Cr-Commit-Position: refs/heads/master@{#407723}

Patch Set 1 : 2016-07-26T10:56:52 #

Messages

Total messages: 16 (9 generated)
yosin_UTC9
PTAL
4 years, 5 months ago (2016-07-26 02:08:28 UTC) #5
tkent
lgtm
4 years, 5 months ago (2016-07-26 02:17:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2178243002/1
4 years, 5 months ago (2016-07-26 02:27:00 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/268802)
4 years, 5 months ago (2016-07-26 04:22:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2178243002/1
4 years, 5 months ago (2016-07-26 05:20:34 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-26 06:30:35 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-26 06:31:44 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d7447926b684013f332153de1bd502dd2bcecb25
Cr-Commit-Position: refs/heads/master@{#407723}

Powered by Google App Engine
This is Rietveld 408576698