Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp

Issue 2178243002: Make ExceptionState parameter of ContainerNode::querySelector() as an optional parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: 2016-07-26T10:56:52 Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp b/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp
index 8d762b26265ad6ee75b9247b6b8f7aa0507ec1b9..e7ef15b4f402eb7c94b134bae5950d44a64dbd43 100644
--- a/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp
@@ -174,9 +174,9 @@ TEST_F(VisibleSelectionTest, ShadowCrossing)
ShadowRoot* shadowRoot = setShadowContent(shadowContent, "host");
Element* body = document().body();
- Element* host = body->querySelector("#host", ASSERT_NO_EXCEPTION);
- Element* one = body->querySelector("#one", ASSERT_NO_EXCEPTION);
- Element* six = shadowRoot->querySelector("#s6", ASSERT_NO_EXCEPTION);
+ Element* host = body->querySelector("#host");
+ Element* one = body->querySelector("#one");
+ Element* six = shadowRoot->querySelector("#s6");
VisibleSelection selection(Position::firstPositionInNode(one), Position::lastPositionInNode(shadowRoot));
VisibleSelectionInFlatTree selectionInFlatTree(PositionInFlatTree::firstPositionInNode(one), PositionInFlatTree::lastPositionInNode(host));
@@ -195,9 +195,9 @@ TEST_F(VisibleSelectionTest, ShadowV0DistributedNodes)
ShadowRoot* shadowRoot = setShadowContent(shadowContent, "host");
Element* body = document().body();
- Element* one = body->querySelector("#one", ASSERT_NO_EXCEPTION);
- Element* two = body->querySelector("#two", ASSERT_NO_EXCEPTION);
- Element* five = shadowRoot->querySelector("#s5", ASSERT_NO_EXCEPTION);
+ Element* one = body->querySelector("#one");
+ Element* two = body->querySelector("#two");
+ Element* five = shadowRoot->querySelector("#s5");
VisibleSelection selection(Position::firstPositionInNode(one), Position::lastPositionInNode(two));
VisibleSelectionInFlatTree selectionInFlatTree(PositionInFlatTree::firstPositionInNode(one), PositionInFlatTree::lastPositionInNode(two));
@@ -226,9 +226,9 @@ TEST_F(VisibleSelectionTest, ShadowNested)
// <span id="s6">66</span>
// </p>
Element* body = document().body();
- Element* host = body->querySelector("#host", ASSERT_NO_EXCEPTION);
- Element* one = body->querySelector("#one", ASSERT_NO_EXCEPTION);
- Element* eight = shadowRoot2->querySelector("#s8", ASSERT_NO_EXCEPTION);
+ Element* host = body->querySelector("#host");
+ Element* one = body->querySelector("#one");
+ Element* eight = shadowRoot2->querySelector("#s8");
VisibleSelection selection(Position::firstPositionInNode(one), Position::lastPositionInNode(shadowRoot2));
VisibleSelectionInFlatTree selectionInFlatTree(PositionInFlatTree::firstPositionInNode(one), PositionInFlatTree::afterNode(eight));

Powered by Google App Engine
This is Rietveld 408576698