third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp - Issue 2178243002: Make ExceptionState parameter of ContainerNode::querySelector() as an optional parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp

Issue 2178243002: Make ExceptionState parameter of ContainerNode::querySelector() as an optional parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: 2016-07-26T10:56:52 Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/RelocatablePositionTest.cpp ('k') | third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp b/third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp

index efd576e2197f4c77f1739f0373b0dfd0ee533021..2b1baab6ed0e4bf2e136f5b2b41d7e6268fd9dc3 100644

--- a/third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp

+++ b/third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp

@@ -20,10 +20,10 @@ TEST_F(VisiblePositionTest, ShadowV0DistributedNodes)

ShadowRoot* shadowRoot = setShadowContent(shadowContent, "host");

Element* body = document().body();

- Element* one = body->querySelector("#one", ASSERT_NO_EXCEPTION);

- Element* two = body->querySelector("#two", ASSERT_NO_EXCEPTION);

- Element* four = shadowRoot->querySelector("#s4", ASSERT_NO_EXCEPTION);

- Element* five = shadowRoot->querySelector("#s5", ASSERT_NO_EXCEPTION);

+ Element* one = body->querySelector("#one");

+ Element* two = body->querySelector("#two");

+ Element* four = shadowRoot->querySelector("#s4");

+ Element* five = shadowRoot->querySelector("#s5");

EXPECT_EQ(Position(one->firstChild(), 0), canonicalPositionOf(Position(one, 0)));

EXPECT_EQ(Position(one->firstChild(), 0), createVisiblePosition(Position(one, 0)).deepEquivalent());