Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2178093003: [snapshot] do not embed string addresses in code. (Closed)

Created:
4 years, 4 months ago by Yang
Modified:
4 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, Rodolph Perfetta (ARM)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[snapshot] do not embed string addresses in code. Doing so in a -pie build would make the snapshot non-deterministic. R=bmeurer@chromium.org BUG=v8:5233 Committed: https://crrev.com/e520e5da5550f0d1a975e87d6e66a2edecbb0c8e Cr-Commit-Position: refs/heads/master@{#38042}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -42 lines) Patch
M src/arm/assembler-arm.cc View 1 1 chunk +5 lines, -1 line 0 comments Download
M src/arm/disasm-arm.cc View 1 1 chunk +4 lines, -10 lines 0 comments Download
M src/arm/simulator-arm.cc View 1 1 chunk +2 lines, -9 lines 0 comments Download
M src/mips/assembler-mips.cc View 1 1 chunk +5 lines, -1 line 0 comments Download
M src/mips/simulator-mips.cc View 1 1 chunk +1 line, -8 lines 0 comments Download
M src/mips64/assembler-mips64.cc View 1 1 chunk +5 lines, -1 line 0 comments Download
M src/mips64/disasm-mips64.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M src/mips64/simulator-mips64.cc View 1 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Yang
4 years, 4 months ago (2016-07-26 07:39:29 UTC) #1
Yang
4 years, 4 months ago (2016-07-26 10:29:52 UTC) #10
Benedikt Meurer
LGTM.
4 years, 4 months ago (2016-07-26 10:30:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2178093003/20001
4 years, 4 months ago (2016-07-26 10:30:54 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-26 10:32:55 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 10:35:25 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e520e5da5550f0d1a975e87d6e66a2edecbb0c8e
Cr-Commit-Position: refs/heads/master@{#38042}

Powered by Google App Engine
This is Rietveld 408576698