Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: src/arm/assembler-arm.cc

Issue 2178093003: [snapshot] do not embed string addresses in code. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: . Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/arm/disasm-arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/arm/assembler-arm.cc
diff --git a/src/arm/assembler-arm.cc b/src/arm/assembler-arm.cc
index 0c9165a303b8ffb7290831a7f4375b6fac0a265c..e94e17a7c87140f5092f661b7f4674157b7c4e32 100644
--- a/src/arm/assembler-arm.cc
+++ b/src/arm/assembler-arm.cc
@@ -2164,7 +2164,11 @@ void Assembler::stop(const char* msg, Condition cond, int32_t code) {
} else {
svc(kStopCode + kMaxStopCode, cond);
}
- emit(reinterpret_cast<Instr>(msg));
+ // Do not embed the message string address! We used to do this, but that
+ // made snapshots created from position-independent executable builds
+ // non-deterministic.
+ // TODO(yangguo): remove this field entirely.
+ nop();
}
#else // def __arm__
if (cond != al) {
« no previous file with comments | « no previous file | src/arm/disasm-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698