Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Side by Side Diff: src/arm/assembler-arm.cc

Issue 2178093003: [snapshot] do not embed string addresses in code. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: . Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm/disasm-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions 5 // modification, are permitted provided that the following conditions
6 // are met: 6 // are met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 2146 matching lines...) Expand 10 before | Expand all | Expand 10 after
2157 DCHECK(code >= kDefaultStopCode); 2157 DCHECK(code >= kDefaultStopCode);
2158 { 2158 {
2159 // The Simulator will handle the stop instruction and get the message 2159 // The Simulator will handle the stop instruction and get the message
2160 // address. It expects to find the address just after the svc instruction. 2160 // address. It expects to find the address just after the svc instruction.
2161 BlockConstPoolScope block_const_pool(this); 2161 BlockConstPoolScope block_const_pool(this);
2162 if (code >= 0) { 2162 if (code >= 0) {
2163 svc(kStopCode + code, cond); 2163 svc(kStopCode + code, cond);
2164 } else { 2164 } else {
2165 svc(kStopCode + kMaxStopCode, cond); 2165 svc(kStopCode + kMaxStopCode, cond);
2166 } 2166 }
2167 emit(reinterpret_cast<Instr>(msg)); 2167 // Do not embed the message string address! We used to do this, but that
2168 // made snapshots created from position-independent executable builds
2169 // non-deterministic.
2170 // TODO(yangguo): remove this field entirely.
2171 nop();
2168 } 2172 }
2169 #else // def __arm__ 2173 #else // def __arm__
2170 if (cond != al) { 2174 if (cond != al) {
2171 Label skip; 2175 Label skip;
2172 b(&skip, NegateCondition(cond)); 2176 b(&skip, NegateCondition(cond));
2173 bkpt(0); 2177 bkpt(0);
2174 bind(&skip); 2178 bind(&skip);
2175 } else { 2179 } else {
2176 bkpt(0); 2180 bkpt(0);
2177 } 2181 }
(...skipping 2073 matching lines...) Expand 10 before | Expand all | Expand 10 after
4251 DCHECK(is_uint12(offset)); 4255 DCHECK(is_uint12(offset));
4252 instr_at_put(pc, SetLdrRegisterImmediateOffset(instr, offset)); 4256 instr_at_put(pc, SetLdrRegisterImmediateOffset(instr, offset));
4253 } 4257 }
4254 } 4258 }
4255 4259
4256 4260
4257 } // namespace internal 4261 } // namespace internal
4258 } // namespace v8 4262 } // namespace v8
4259 4263
4260 #endif // V8_TARGET_ARCH_ARM 4264 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm/disasm-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698