Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2177763002:
WebGL 2: Update expectations. (Closed)
|
Created:
4 years, 5 months ago by Jamie Madill Modified:
4 years, 5 months ago Reviewers:
Zhenyao Mo CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, Ken Russell (switch to Gerrit) Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionWebGL 2: Update expectations.
BUG=628954, 483282, 478572
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=zmo@chromium.org
NOTRY=true
Committed: https://crrev.com/dd5bcd3ee0e38d0622de580545fdfe43f4131395
Cr-Commit-Position: refs/heads/master@{#407371}
Patch Set 1 #Patch Set 2 : Update expects #
Total comments: 1
Patch Set 3 : Flaky->fail, and add mac flake #
Total comments: 1
Patch Set 4 : Wrap long line #Messages
Total messages: 25 (14 generated)
Description was changed from ========== WebGL 2: Update expectations. BUG=628954, 483282 ========== to ========== WebGL 2: Update expectations. BUG=628954, 483282 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== WebGL 2: Update expectations. BUG=628954, 483282 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== WebGL 2: Update expectations. BUG=628954, 483282, 478572 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=zmo@chromium.org ==========
The CQ bit was checked by jmadill@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
zmo@chromium.org changed reviewers: + zmo@chromium.org
This is beautiful. https://codereview.chromium.org/2177763002/diff/20001/content/test/gpu/gpu_te... File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right): https://codereview.chromium.org/2177763002/diff/20001/content/test/gpu/gpu_te... content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:92: self.Flaky('deqp/functional/gles3/shadercommonfunction.html', for what's it's worth, we already marked everything flaky in AMD (right after this entry), so this probably need to be marked as fail to be effective. It apparently fails more often than not.
lgtm
The CQ bit was checked by jmadill@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by jmadill@chromium.org
Description was changed from ========== WebGL 2: Update expectations. BUG=628954, 483282, 478572 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=zmo@chromium.org ========== to ========== WebGL 2: Update expectations. BUG=628954, 483282, 478572 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=zmo@chromium.org NOTRY=true ==========
The CQ bit was checked by jmadill@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org Link to the patchset: https://codereview.chromium.org/2177763002/#ps40001 (title: "Flaky->fail, and add mac flake")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
https://codereview.chromium.org/2177763002/diff/40001/content/test/gpu/gpu_te... File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right): https://codereview.chromium.org/2177763002/diff/40001/content/test/gpu/gpu_te... content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:356: self.Flaky('deqp/functional/gles3/vertexarrays/multiple_attributes.output.html', this is over 80 char.
The CQ bit was checked by jmadill@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org Link to the patchset: https://codereview.chromium.org/2177763002/#ps60001 (title: "Wrap long line")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== WebGL 2: Update expectations. BUG=628954, 483282, 478572 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=zmo@chromium.org NOTRY=true ========== to ========== WebGL 2: Update expectations. BUG=628954, 483282, 478572 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=zmo@chromium.org NOTRY=true Committed: https://crrev.com/dd5bcd3ee0e38d0622de580545fdfe43f4131395 Cr-Commit-Position: refs/heads/master@{#407371} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/dd5bcd3ee0e38d0622de580545fdfe43f4131395 Cr-Commit-Position: refs/heads/master@{#407371} |
