Revert "Allow SequencedTaskRunnerHandle::Get() while running unsequenced tasks."

Revert "Allow SequencedTaskRunnerHandle::Get() while running unsequenced tasks."

This is effectively a manual revert of 5d315e4b4a7cdef34b0c1e863353d03a30781217.

Per the outcome of the discussion on http://crbug.com/618043 and associated doc/chromium-dev discussion.

BUG=618043
Committed: https://crrev.com/41339c7ae8458dd500d1be0e9d4b8da6d8c4c33b
Committed: https://crrev.com/a414e99dbf38480dc4ac6e69368c2b13b0b6a0f0
Cr-Original-Commit-Position: refs/heads/master@{#408440}
Cr-Commit-Position: refs/heads/master@{#408992}

[gab, 2016-07-27 17:39:04]

Description was changed from

==========
Revert "Allow SequencedTaskRunnerHandle::Get() while running unsequenced tasks."

This effectively a manual revert of 5d315e4b4a7cdef34b0c1e863353d03a30781217.

BUG=618043
==========

to

==========
Revert "Allow SequencedTaskRunnerHandle::Get() while running unsequenced tasks."

This is effectively a manual revert of 5d315e4b4a7cdef34b0c1e863353d03a30781217.

BUG=618043
==========

[gab, 2016-07-27 17:39:38]

Patchset #1 (id:1) has been deleted

[gab, 2016-07-27 17:49:28]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 17:49:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2016-07-27 17:52:32]

Description was changed from

==========
Revert "Allow SequencedTaskRunnerHandle::Get() while running unsequenced tasks."

This is effectively a manual revert of 5d315e4b4a7cdef34b0c1e863353d03a30781217.

BUG=618043
==========

to

==========
Revert "Allow SequencedTaskRunnerHandle::Get() while running unsequenced tasks."

This is effectively a manual revert of 5d315e4b4a7cdef34b0c1e863353d03a30781217.

Per the outcome of the discussion on http://crbug.com/618043 and associated
doc/chromium-dev discussion.

BUG=618043
==========

[gab, 2016-07-27 17:52:39]

gab@chromium.org changed reviewers:
+ danakj@chromium.org

[gab, 2016-07-27 17:52:40]

Dana PTAL, thanks!

[commit-bot: I haz the power, 2016-07-27 19:29:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 19:29:58]

Dry run: This issue passed the CQ dry run.

[danakj, 2016-07-27 21:22:52]

LGTM

https://codereview.chromium.org/2177373005/diff/20001/base/threading/sequence...
File base/threading/sequenced_task_runner_handle.cc (right):

https://codereview.chromium.org/2177373005/diff/20001/base/threading/sequence...
base/threading/sequenced_task_runner_handle.cc:54:
(SequencedWorkerPool::GetWorkerPoolForCurrentThread() &&
doesnt a valid token imply there's a worker pool?

https://codereview.chromium.org/2177373005/diff/20001/base/threading/sequence...
File base/threading/sequenced_worker_pool.cc (right):

https://codereview.chromium.org/2177373005/diff/20001/base/threading/sequence...
base/threading/sequenced_worker_pool.cc:1242: // Avoid deleting ourselves on a
worker thread (which would
could leave this better wrapping

[gab, 2016-07-28 14:13:31]

https://codereview.chromium.org/2177373005/diff/20001/base/threading/sequence...
File base/threading/sequenced_task_runner_handle.cc (right):

https://codereview.chromium.org/2177373005/diff/20001/base/threading/sequence...
base/threading/sequenced_task_runner_handle.cc:54:
(SequencedWorkerPool::GetWorkerPoolForCurrentThread() &&
On 2016/07/27 21:22:52, danakj wrote:
> doesnt a valid token imply there's a worker pool?

Ah indeed :-), the reverted code was over-specific in this condition, fixed.

https://codereview.chromium.org/2177373005/diff/20001/base/threading/sequence...
File base/threading/sequenced_worker_pool.cc (right):

https://codereview.chromium.org/2177373005/diff/20001/base/threading/sequence...
base/threading/sequenced_worker_pool.cc:1242: // Avoid deleting ourselves on a
worker thread (which would
On 2016/07/27 21:22:52, danakj wrote:
> could leave this better wrapping

Oops, not quite sure how this happened, <ENTER> in wrong window I guess..
thanks!

[gab, 2016-07-28 14:13:46]

The CQ bit was checked by gab@chromium.org

[gab, 2016-07-28 14:13:47]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2177373005/#ps40001
(title: "nits")

[commit-bot: I haz the power, 2016-07-28 14:14:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 15:16:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 15:16:09]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[gab, 2016-07-28 17:31:45]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2016-07-28 17:32:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 18:38:39]

Description was changed from

==========
Revert "Allow SequencedTaskRunnerHandle::Get() while running unsequenced tasks."

This is effectively a manual revert of 5d315e4b4a7cdef34b0c1e863353d03a30781217.

Per the outcome of the discussion on http://crbug.com/618043 and associated
doc/chromium-dev discussion.

BUG=618043
==========

to

==========
Revert "Allow SequencedTaskRunnerHandle::Get() while running unsequenced tasks."

This is effectively a manual revert of 5d315e4b4a7cdef34b0c1e863353d03a30781217.

Per the outcome of the discussion on http://crbug.com/618043 and associated
doc/chromium-dev discussion.

BUG=618043
==========

[commit-bot: I haz the power, 2016-07-28 18:38:40]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-07-28 18:43:33]

Description was changed from

==========
Revert "Allow SequencedTaskRunnerHandle::Get() while running unsequenced tasks."

This is effectively a manual revert of 5d315e4b4a7cdef34b0c1e863353d03a30781217.

Per the outcome of the discussion on http://crbug.com/618043 and associated
doc/chromium-dev discussion.

BUG=618043
==========

to

==========
Revert "Allow SequencedTaskRunnerHandle::Get() while running unsequenced tasks."

This is effectively a manual revert of 5d315e4b4a7cdef34b0c1e863353d03a30781217.

Per the outcome of the discussion on http://crbug.com/618043 and associated
doc/chromium-dev discussion.

BUG=618043

Committed: https://crrev.com/41339c7ae8458dd500d1be0e9d4b8da6d8c4c33b
Cr-Commit-Position: refs/heads/master@{#408440}
==========

[commit-bot: I haz the power, 2016-07-28 18:43:34]

Patchset 2 (id:??) landed as
https://crrev.com/41339c7ae8458dd500d1be0e9d4b8da6d8c4c33b
Cr-Commit-Position: refs/heads/master@{#408440}

[gab, 2016-07-28 19:04:12]

A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/2190073002/ by gab@chromium.org.

The reason for reverting is: Actually oops forgot this wasn't supposed to land
until this blocker is resolved :
https://bugs.chromium.org/p/chromium/issues/detail?id=618043#c5.

[gab, 2016-07-30 17:44:25]

Description was changed from

==========
Revert "Allow SequencedTaskRunnerHandle::Get() while running unsequenced tasks."

This is effectively a manual revert of 5d315e4b4a7cdef34b0c1e863353d03a30781217.

Per the outcome of the discussion on http://crbug.com/618043 and associated
doc/chromium-dev discussion.

BUG=618043

Committed: https://crrev.com/41339c7ae8458dd500d1be0e9d4b8da6d8c4c33b
Cr-Commit-Position: refs/heads/master@{#408440}
==========

to

==========
Revert "Allow SequencedTaskRunnerHandle::Get() while running unsequenced tasks."

This is effectively a manual revert of 5d315e4b4a7cdef34b0c1e863353d03a30781217.

Per the outcome of the discussion on http://crbug.com/618043 and associated
doc/chromium-dev discussion.

BUG=618043

Committed: https://crrev.com/41339c7ae8458dd500d1be0e9d4b8da6d8c4c33b
Cr-Commit-Position: refs/heads/master@{#408440}
==========

[gab, 2016-07-30 17:44:32]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2016-07-30 17:44:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 17:46:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-30 17:46:32]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[gab, 2016-08-01 15:30:21]

The CQ bit was checked by gab@chromium.org

[gab, 2016-08-01 15:30:22]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2177373005/#ps60001
(title: "merge up to r408965")

[commit-bot: I haz the power, 2016-08-01 15:30:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 17:30:09]

Description was changed from

==========
Revert "Allow SequencedTaskRunnerHandle::Get() while running unsequenced tasks."

This is effectively a manual revert of 5d315e4b4a7cdef34b0c1e863353d03a30781217.

Per the outcome of the discussion on http://crbug.com/618043 and associated
doc/chromium-dev discussion.

BUG=618043

Committed: https://crrev.com/41339c7ae8458dd500d1be0e9d4b8da6d8c4c33b
Cr-Commit-Position: refs/heads/master@{#408440}
==========

to

==========
Revert "Allow SequencedTaskRunnerHandle::Get() while running unsequenced tasks."

This is effectively a manual revert of 5d315e4b4a7cdef34b0c1e863353d03a30781217.

Per the outcome of the discussion on http://crbug.com/618043 and associated
doc/chromium-dev discussion.

BUG=618043

Committed: https://crrev.com/41339c7ae8458dd500d1be0e9d4b8da6d8c4c33b
Cr-Commit-Position: refs/heads/master@{#408440}
==========

[commit-bot: I haz the power, 2016-08-01 17:30:10]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-08-01 17:33:33]

Description was changed from

==========
Revert "Allow SequencedTaskRunnerHandle::Get() while running unsequenced tasks."

This is effectively a manual revert of 5d315e4b4a7cdef34b0c1e863353d03a30781217.

Per the outcome of the discussion on http://crbug.com/618043 and associated
doc/chromium-dev discussion.

BUG=618043

Committed: https://crrev.com/41339c7ae8458dd500d1be0e9d4b8da6d8c4c33b
Cr-Commit-Position: refs/heads/master@{#408440}
==========

to

==========
Revert "Allow SequencedTaskRunnerHandle::Get() while running unsequenced tasks."

This is effectively a manual revert of 5d315e4b4a7cdef34b0c1e863353d03a30781217.

Per the outcome of the discussion on http://crbug.com/618043 and associated
doc/chromium-dev discussion.

BUG=618043

Committed: https://crrev.com/41339c7ae8458dd500d1be0e9d4b8da6d8c4c33b
Committed: https://crrev.com/a414e99dbf38480dc4ac6e69368c2b13b0b6a0f0
Cr-Original-Commit-Position: refs/heads/master@{#408440}
Cr-Commit-Position: refs/heads/master@{#408992}
==========

[commit-bot: I haz the power, 2016-08-01 17:33:34]

Patchset 3 (id:??) landed as
https://crrev.com/a414e99dbf38480dc4ac6e69368c2b13b0b6a0f0
Cr-Commit-Position: refs/heads/master@{#408992}