Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(971)

Unified Diff: base/threading/sequenced_task_runner_handle.cc

Issue 2177373005: Revert "Allow SequencedTaskRunnerHandle::Get() while running unsequenced tasks." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge up to r408965 Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/threading/sequenced_task_runner_handle.cc
diff --git a/base/threading/sequenced_task_runner_handle.cc b/base/threading/sequenced_task_runner_handle.cc
index 88b36a8d648694cf892816389dc49ff2e15454c0..db96a6ada942741d6b3b8b96946c56680340afdd 100644
--- a/base/threading/sequenced_task_runner_handle.cc
+++ b/base/threading/sequenced_task_runner_handle.cc
@@ -28,16 +28,20 @@ scoped_refptr<SequencedTaskRunner> SequencedTaskRunnerHandle::Get() {
if (handle) {
// Various modes of setting SequencedTaskRunnerHandle don't combine.
DCHECK(!base::ThreadTaskRunnerHandle::IsSet());
- DCHECK(!SequencedWorkerPool::GetSequencedTaskRunnerForCurrentThread());
+ DCHECK(!SequencedWorkerPool::GetSequenceTokenForCurrentThread().IsValid());
return handle->task_runner_;
}
- // Return the SequencedTaskRunner obtained from SequencedWorkerPool, if any.
- scoped_refptr<base::SequencedTaskRunner> task_runner =
- SequencedWorkerPool::GetSequencedTaskRunnerForCurrentThread();
- if (task_runner) {
- DCHECK(!base::ThreadTaskRunnerHandle::IsSet());
- return task_runner;
+ // If we are on a worker thread for a SequencedBlockingPool that is running a
+ // sequenced task, return a SequencedTaskRunner for it.
+ scoped_refptr<base::SequencedWorkerPool> pool =
+ SequencedWorkerPool::GetWorkerPoolForCurrentThread();
+ if (pool) {
+ SequencedWorkerPool::SequenceToken sequence_token =
+ SequencedWorkerPool::GetSequenceTokenForCurrentThread();
+ DCHECK(sequence_token.IsValid());
+ DCHECK(pool->IsRunningSequenceOnCurrentThread(sequence_token));
+ return pool->GetSequencedTaskRunner(sequence_token);
}
// Return the SingleThreadTaskRunner for the current thread otherwise.
@@ -47,7 +51,7 @@ scoped_refptr<SequencedTaskRunner> SequencedTaskRunnerHandle::Get() {
// static
bool SequencedTaskRunnerHandle::IsSet() {
return lazy_tls_ptr.Pointer()->Get() ||
- SequencedWorkerPool::GetWorkerPoolForCurrentThread() ||
+ SequencedWorkerPool::GetSequenceTokenForCurrentThread().IsValid() ||
base::ThreadTaskRunnerHandle::IsSet();
}
« no previous file with comments | « base/threading/sequenced_task_runner_handle.h ('k') | base/threading/sequenced_task_runner_handle_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698