Move SearchProvider implementation into Blink and make it a no-op.

Move SearchProvider implementation into Blink and make it a no-op.

BUG=545585, 631325
Committed: https://crrev.com/c4fc2c3302b82b57d9a4dfcef4d9c8e292f710d0
Cr-Commit-Position: refs/heads/master@{#408307}

[dcheng, 2016-07-25 07:29:56]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 07:30:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2016-07-25 07:30:07]

Description was changed from

==========
Move SearchProvider implementation into Blink and make it a no-op.

BUG=545585,542487
==========

to

==========
Move SearchProvider implementation into Blink and make it a no-op.

BUG=545585,542487
==========

[dcheng, 2016-07-25 07:30:07]

dcheng@chromium.org changed reviewers:
+ jam@chromium.org, jochen@chromium.org

[commit-bot: I haz the power, 2016-07-25 07:33:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 07:33:27]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dcheng, 2016-07-25 07:37:08]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 07:37:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 07:40:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 07:40:43]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dcheng, 2016-07-25 09:37:26]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 09:37:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 10:36:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 10:37:00]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dcheng, 2016-07-26 00:30:31]

I need to rebaseline some of the tests, but none of the test failures seem
out-of-line with what you'd expect with this feature turned into a no-op.

[dcheng, 2016-07-26 00:30:55]

(Also, I'm not sure if this needs a new intent to implement and ship, probably,
I assume. So I'll just crib off estade's originaly email)

[dcheng, 2016-07-26 08:06:56]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 08:07:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 09:38:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 09:38:18]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dcheng, 2016-07-26 12:34:31]

Description was changed from

==========
Move SearchProvider implementation into Blink and make it a no-op.

BUG=545585,542487
==========

to

==========
Move SearchProvider implementation into Blink and make it a no-op.

BUG=545585,631325
==========

[dcheng, 2016-07-26 12:36:33]

I went ahead and filed an intent: https://crbug.com/631325

I'll wait to land this until the intent gets LGTMs and the corresponding launch
bug has the appropriate reviews

[dcheng, 2016-07-26 13:14:34]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 13:14:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 14:46:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 14:46:09]

Dry run: This issue passed the CQ dry run.

[jam, 2016-07-26 17:04:55]

Thanks for doing this.

can also delete chrome/browser/search_engines/search_provider_install_data*

https://codereview.chromium.org/2177123003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/frame/External.idl (right):

https://codereview.chromium.org/2177123003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/External.idl:8: void
IsSearchProviderInstalled();
this has an integer return value per the spec.

edge returns 2 always after the depreciation, see the link in the blink-dev
thread where they said that after a long discussion they decided on this value
(i.e. search is set) so that websites don't spam users to change the default

[jam, 2016-07-26 17:09:23]

https://codereview.chromium.org/2177123003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/frame/External.idl (right):

https://codereview.chromium.org/2177123003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/External.idl:8: void
IsSearchProviderInstalled();
On 2016/07/26 17:04:55, jam wrote:
> this has an integer return value per the spec.
> 
> edge returns 2 always after the depreciation, see the link in the blink-dev
> thread where they said that after a long discussion they decided on this value
> (i.e. search is set) so that websites don't spam users to change the default

oh actually nvm, i see from your intent email that the spec says no return
value.

[dcheng, 2016-07-27 00:16:26]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 00:17:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2016-07-27 00:18:38]

Deleted search_provider_install_data as well now, thanks for the pointer.

https://codereview.chromium.org/2177123003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/frame/External.idl (right):

https://codereview.chromium.org/2177123003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/External.idl:8: void
IsSearchProviderInstalled();
On 2016/07/26 17:09:23, jam wrote:
> On 2016/07/26 17:04:55, jam wrote:
> > this has an integer return value per the spec.
> > 
> > edge returns 2 always after the depreciation, see the link in the blink-dev
> > thread where they said that after a long discussion they decided on this
value
> > (i.e. search is set) so that websites don't spam users to change the default
> 
> oh actually nvm, i see from your intent email that the spec says no return
> value.

Yeah, let me talk to domenic and see if he has any thoughts on this.

[dcheng, 2016-07-27 01:33:17]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 01:33:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 05:11:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 05:12:00]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-07-27 07:34:35]

lgtm

https://codereview.chromium.org/2177123003/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/frame/External.h (right):

https://codereview.chromium.org/2177123003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/External.h:14: DEFINE_WRAPPERTYPEINFO();
wtf_make_noncopiable?

https://codereview.chromium.org/2177123003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/External.h:16: External() { }
= default?

[dcheng, 2016-07-27 08:00:54]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 08:01:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2016-07-27 08:01:59]

https://codereview.chromium.org/2177123003/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/frame/External.h (right):

https://codereview.chromium.org/2177123003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/External.h:14: DEFINE_WRAPPERTYPEINFO();
On 2016/07/27 07:34:35, jochen wrote:
> wtf_make_noncopiable?

That's true for all things that derive from GarbageCollected<T>. We don't have a
strong convention of doing this elsewhere (in fact, most code usually doesn't
spell this out), so I think for consistency, we should leave it out here?

https://codereview.chromium.org/2177123003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/External.h:16: External() { }
On 2016/07/27 07:34:35, jochen wrote:
> = default?

Done, but any particular reason for doing so? It's more characters to write it
out, and I think it won't give this class a trivial constructor anyway:
http://stackoverflow.com/questions/20828907/the-new-keyword-default-in-c11

[commit-bot: I haz the power, 2016-07-27 11:13:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 11:13:28]

Dry run: This issue passed the CQ dry run.

[jam, 2016-07-27 17:25:09]

lgtm

[dcheng, 2016-07-28 01:18:47]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-07-28 01:18:48]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2177123003/#ps160001
(title: ".")

[commit-bot: I haz the power, 2016-07-28 01:19:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 01:23:57]

Description was changed from

==========
Move SearchProvider implementation into Blink and make it a no-op.

BUG=545585,631325
==========

to

==========
Move SearchProvider implementation into Blink and make it a no-op.

BUG=545585,631325
==========

[commit-bot: I haz the power, 2016-07-28 01:24:00]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-07-28 01:26:21]

Description was changed from

==========
Move SearchProvider implementation into Blink and make it a no-op.

BUG=545585,631325
==========

to

==========
Move SearchProvider implementation into Blink and make it a no-op.

BUG=545585,631325

Committed: https://crrev.com/c4fc2c3302b82b57d9a4dfcef4d9c8e292f710d0
Cr-Commit-Position: refs/heads/master@{#408307}
==========

[commit-bot: I haz the power, 2016-07-28 01:26:23]

Patchset 9 (id:??) landed as
https://crrev.com/c4fc2c3302b82b57d9a4dfcef4d9c8e292f710d0
Cr-Commit-Position: refs/heads/master@{#408307}